From mboxrd@z Thu Jan  1 00:00:00 1970
Date: Wed, 23 Apr 2008 17:04:15 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [BUGFIX][PATCH] Fix usemap initialization v3
Message-Id: <20080423170415.00190051.kamezawa.hiroyu@jp.fujitsu.com>
In-Reply-To: <480ED4D8.5070607@cn.fujitsu.com>
References: <20080418161522.GB9147@csn.ul.ie>
	<48080706.50305@cn.fujitsu.com>
	<48080930.5090905@cn.fujitsu.com>
	<48080B86.7040200@cn.fujitsu.com>
	<20080418211214.299f91cd.kamezawa.hiroyu@jp.fujitsu.com>
	<21878461.1208539556838.kamezawa.hiroyu@jp.fujitsu.com>
	<20080421112048.78f0ec76.kamezawa.hiroyu@jp.fujitsu.com>
	<Pine.LNX.4.64.0804211250000.16476@blonde.site>
	<20080422104043.215c7dc4.kamezawa.hiroyu@jp.fujitsu.com>
	<20080423134621.6020dd83.kamezawa.hiroyu@jp.fujitsu.com>
	<480ED4D8.5070607@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-linux-mm@kvack.org
Return-Path: <owner-linux-mm@kvack.org>
To: Shi Weihua <shiwh@cn.fujitsu.com>
Cc: akpm@linux-foundation.org, Hugh Dickins <hugh@veritas.com>, Mel Gorman <mel@csn.ul.ie>, balbir@linux.vnet.ibm.com, xemul@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>

On Wed, 23 Apr 2008 14:19:04 +0800
Shi Weihua <shiwh@cn.fujitsu.com> wrote:

> KAMEZAWA Hiroyuki wrote::
> > fixed typos.
> > ==
> > usemap must be initialized only when pfn is within zone.
> > If not, it corrupts memory.
> > 
> > And this patch also reduces the number of calls to set_pageblock_migratetype()
> > from
> > 	(pfn & (pageblock_nr_pages -1)
> > to
> > 	!(pfn & (pageblock_nr_pages-1)
> > it should be called once per pageblock.
> > 
> > Changelog.
> > v2->v3
> >  - Fixed typos.
> > v1->v2
> >  - Fixed boundary check.
> >  - Move calculation of pointer for zone struct to out of loop.
> 
> I noticed v3 takes "zone" instead of "zid" in the code line 
> "z = &NODE_DATA(nid)->node_zones[zone];".
> I tested v3, it works well now.
> 
I don't understand why this happens. (I compiled and tested v2...)
v3's "zone" is correct. thank you!

Regards,
-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>