Re: [BUGFIX][PATCH] Fix usemap initialization v3

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Wed, 23 Apr 2008 14:19:04 +0800
Shi Weihua <shiwh@cn.fujitsu.com> wrote:

> KAMEZAWA Hiroyuki wrote::
> > fixed typos.
> > ==
> > usemap must be initialized only when pfn is within zone.
> > If not, it corrupts memory.
> > 
> > And this patch also reduces the number of calls to set_pageblock_migratetype()
> > from
> > 	(pfn & (pageblock_nr_pages -1)
> > to
> > 	!(pfn & (pageblock_nr_pages-1)
> > it should be called once per pageblock.
> > 
> > Changelog.
> > v2->v3
> >  - Fixed typos.
> > v1->v2
> >  - Fixed boundary check.
> >  - Move calculation of pointer for zone struct to out of loop.
> 
> I noticed v3 takes "zone" instead of "zid" in the code line 
> "z = &NODE_DATA(nid)->node_zones[zone];".
> I tested v3, it works well now.
> 
I don't understand why this happens. (I compiled and tested v2...)
v3's "zone" is correct. thank you!

Regards,
-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>