Re: [PATCH]Fix usemap for DISCONTIG/FLATMEM with not-aligned zone initilaization.

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Mon, 21 Apr 2008 11:12:32 +0100
Mel Gorman <mel@csn.ul.ie> wrote:

> On (21/04/08 11:20), KAMEZAWA Hiroyuki didst pronounce:
> > On Sat, 19 Apr 2008 02:25:56 +0900 (JST)
> > kamezawa.hiroyu@jp.fujitsu.com wrote:
> >  
> > > >What about something like the following? Instead of expanding the size of
> > > >structures, it sanity checks input parameters. It touches a number of places
> > > >because of an API change but it is otherwise straight-forward.
> > > >
> > > >Unfortunately, I do not have an IA-64 machine that can reproduce the problem
> > > >to see if this still fixes it or not so a test as well as a review would be
> > > >appreciated. What should happen is the machine boots but prints a warning
> > > >about the unexpected PFN ranges. It boot-tested fine on a number of other
> > > >machines (x86-32 x86-64 and ppc64).
> > > >
> > > ok, I'll test today if I have a chance. At least, I think I can test this
> > > until Monday. but I have one concern (below)
> > > 
> > I tested and found your patch doesn't work.
> > It seems because all valid page struct is not initialized.
> 
> The fact I didn't calculate end_pfn properly as pointed out by Dave Hansen
> didn't help either. If that was corrected, I'd be surprised if the patch
> didn't work. If it is broken, it implies that arch-specific code is using
> PFN ranges that do not contain valid memory - something I find surprising.
> 
I noticed and fixed end_pfn but did not work....If necessary, I'll check it
again....

Thanks,
-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>