From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Subject: Re: 2.6.25-mm1: not looking good Date: Fri, 18 Apr 2008 10:57:12 -0400 References: <20080417160331.b4729f0c.akpm@linux-foundation.org> <200804171955.46600.paul.moore@hp.com> <20080417183538.d88feff5.akpm@linux-foundation.org> In-Reply-To: <20080417183538.d88feff5.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200804181057.12246.paul.moore@hp.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: mingo@elte.hu, tglx@linutronix.de, penberg@cs.helsinki.fi, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, jmorris@namei.org, sds@tycho.nsa.gov List-ID: On Thursday 17 April 2008 9:35:38 pm Andrew Morton wrote: > I dropped git-selinux and that crash seems to have gone away. It > took about five minutes before, but would presumably have happened > earlier if I'd reduced the cache size. > > btw, wouldn't this > > --- a/security/selinux/netnode.c~a > +++ a/security/selinux/netnode.c > @@ -190,7 +190,7 @@ static int sel_netnode_insert(struct sel > if (sel_netnode_hash[idx].size == SEL_NETNODE_HASH_BKT_LIMIT) { > struct sel_netnode *tail; > tail = list_entry(node->list.prev, struct sel_netnode, list); > - list_del_rcu(node->list.prev); > + list_del_rcu(&tail->list); > call_rcu(&tail->rcu, sel_netnode_free); > } else > sel_netnode_hash[idx].size++; > _ > > be a bit clearer? If it's correct - I didn't try too hard :) Looks good to me, although before I fix this let me try and figure out why this code is causing the machine to puke all over itself. Priorities you know :) -- paul moore linux @ hp -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org