From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 16 Apr 2008 16:04:31 +0200 From: Ingo Molnar Subject: Re: [PATCH 1/4] Add a basic debugging framework for memory initialisation Message-ID: <20080416140431.GD24383@elte.hu> References: <20080416135058.1346.65546.sendpatchset@skynet.skynet.ie> <20080416135118.1346.72244.sendpatchset@skynet.skynet.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080416135118.1346.72244.sendpatchset@skynet.skynet.ie> Sender: owner-linux-mm@kvack.org Return-Path: To: Mel Gorman Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: * Mel Gorman wrote: > +static __init int set_mminit_debug_level(char *str) > +{ > + get_option(&str, &mminit_debug_level); > + return 0; > +} > +early_param("mminit_debug_level", set_mminit_debug_level); another small suggestion: could you please also add a Kconfig method of enabling it, dependent on KERNEL_DEBUG, default-off (for now). The best would be not a numeric switch but something that gets randomized by "make randconfig". I.e. an on/off switch kind of things. Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org