From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 15 Apr 2008 12:12:48 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH] use vmalloc for mem_cgroup allocation. v2 Message-Id: <20080415121248.c1318b1b.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20080414192042.c50d8d58.akpm@linux-foundation.org> References: <20080415105434.3044afb6.kamezawa.hiroyu@jp.fujitsu.com> <20080415111038.ffac0e12.kamezawa.hiroyu@jp.fujitsu.com> <48040E19.2090007@cn.fujitsu.com> <20080414192042.c50d8d58.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: Li Zefan , "balbir@linux.vnet.ibm.com" , "xemul@openvz.org" , menage@google.com, "linux-mm@kvack.org" , LKML List-ID: On Mon, 14 Apr 2008 19:20:42 -0700 Andrew Morton wrote: > On Tue, 15 Apr 2008 10:08:25 +0800 Li Zefan wrote: > > > > @@ -992,8 +993,10 @@ mem_cgroup_create(struct cgroup_subsys * > > > if (unlikely((cont->parent) == NULL)) { > > > mem = &init_mem_cgroup; > > > page_cgroup_cache = KMEM_CACHE(page_cgroup, SLAB_PANIC); > > > - } else > > > - mem = kzalloc(sizeof(struct mem_cgroup), GFP_KERNEL); > > > + } else { > > > + mem = vmalloc(sizeof(struct mem_cgroup)); > > > + memset(mem, 0, sizeof(*mem)); > > > > what if mem == NULL. ;) > > > > > + } > > > > > > if (mem == NULL) > > > return ERR_PTR(-ENOMEM); > > > > So we can move this NULL check to the above else branch, in the if brach, > > mem won't be NULL. > > err, yes. > > So I have: > > if (unlikely((cont->parent) == NULL)) { > mem = &init_mem_cgroup; > page_cgroup_cache = KMEM_CACHE(page_cgroup, SLAB_PANIC); > } else { > mem = vmalloc(sizeof(struct mem_cgroup)); > if (mem == NULL) > return ERR_PTR(-ENOMEM); > memset(mem, 0, sizeof(*mem)); > } > Sorry for poor patch.... And thank you for catching. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org