From: Andi Kleen <andi@firstfloor.org>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: andi@firstfloor.org, Andrew Morton <akpm@linux-foundation.org>,
YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
Paul Menage <menage@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Pavel Emelianov <xemul@openvz.org>,
hugh@veritas.com,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [-mm] Disable the memory controller by default
Date: Mon, 7 Apr 2008 14:03:40 +0200 [thread overview]
Message-ID: <20080407120340.GB16647@one.firstfloor.org> (raw)
In-Reply-To: <20080407115137.24124.59692.sendpatchset@localhost.localdomain>
On Mon, Apr 07, 2008 at 05:21:37PM +0530, Balbir Singh wrote:
>
>
> Due to the overhead of the memory controller. The
> memory controller is now disabled by default. This patch changes
> cgroup_disable to cgroup_toggle, so that each controller can decide
> whether it wants to be enabled/disabled by default.
>
> If everyone agrees on this approach and likes it, should we push this
> into 2.6.25?
First I like the change to make it disabled by default.
I don't think "toggle" is good semantics for a user visible switch
because that changes the meaning when the kernel default changes
(which it will likely once the current default overhead is fixed)
It should be rather: cgroup=on/off
-Andi
next prev parent reply other threads:[~2008-04-07 12:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-07 11:51 Balbir Singh
2008-04-07 12:03 ` Andi Kleen [this message]
2008-04-07 12:03 ` Balbir Singh
2008-04-07 12:16 ` Andi Kleen
2008-04-07 12:16 ` KOSAKI Motohiro
2008-04-07 12:16 ` Balbir Singh
2008-04-07 17:48 ` Paul Menage
2008-04-07 12:12 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080407120340.GB16647@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hugh@veritas.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox