Re: [PATCH 8/8] x86_64: Support for new UV apic

[Jack Steiner <steiner@sgi.com>]

On Sun, Mar 30, 2008 at 07:27:25PM -0700, Yinghai Lu wrote:
> On Sun, Mar 30, 2008 at 7:23 PM, Jack Steiner <steiner@sgi.com> wrote:
> >
> > On Sun, Mar 30, 2008 at 07:13:42PM -0700, Yinghai Lu wrote:
> >  > On Sun, Mar 30, 2008 at 7:06 PM, Jack Steiner <steiner@sgi.com> wrote:
> >  > > > so this is "the new one of Friday"?
> >  > >
> >  > >  Yes, and it has the same bug although it is located
> >  > >  in a slightly different place.
> >  > >
> >  > >  A few minutes ago, I posted a patch to delete the extra lines.
> >  > >
> >  > >
> >  > >
> >  > >  > Did you test it on non UV_X2APIC box?
> >  > >
> >  > >  The code is clearly wrong.  I booted on an 8p AMD box and
> >  > >  had no problems. Apparently the kernel (at least basic booting) is
> >  > >  not too sensitive to incorrect apicids being returned. Most
> >  > >  critical-to-boot code must use apicids from the ACPI tables.
> >  > >  However, the bug does affect numa node assignment. And probably
> >  > >  other places, too.
> >  >
> >  > please consider one global get_apic_id() and bad_apicid to replace
> >  > GET_APIC_ID and BAD_APICID at this point.
> >
> >  I think that makes sense.
> >
> >  The x2apic patch that should be posted in the near future also makes
> >  significant changes in this area.  Once that patch is posted, I'll
> >  make the simplifications.
> >
> >  Ok???
> 
> good.
> 
> with the x2apic patch, GET_APIC_ID is read_apic_id, and it will not shift again?
> 
> YH

Right....

--- jack

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>