From: Ingo Molnar <mingo@elte.hu>
To: Jack Steiner <steiner@sgi.com>
Cc: tglx@linutronix.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] x86_64: Support for new UV apic
Date: Fri, 28 Mar 2008 21:15:32 +0100 [thread overview]
Message-ID: <20080328201532.GB26555@elte.hu> (raw)
In-Reply-To: <20080328191216.GA16455@sgi.com>
* Jack Steiner <steiner@sgi.com> wrote:
> Index: linux/arch/x86/kernel/apic_64.c
> ===================================================================
> --- linux.orig/arch/x86/kernel/apic_64.c 2008-03-28 13:00:22.000000000 -0500
> +++ linux/arch/x86/kernel/apic_64.c 2008-03-28 13:06:12.000000000 -0500
> @@ -738,6 +738,7 @@ void __cpuinit setup_local_APIC(void)
> unsigned int value;
> int i, j;
>
> + preempt_disable();
> value = apic_read(APIC_LVR);
>
> BUILD_BUG_ON((SPURIOUS_APIC_VECTOR & 0x0f) != 0x0f);
> @@ -831,6 +832,7 @@ void __cpuinit setup_local_APIC(void)
> else
> value = APIC_DM_NMI | APIC_LVT_MASKED;
> apic_write(APIC_LVT1, value);
> + preempt_enable();
> }
hm, this looks a bit weird - why are all the preempt-disable/enable
calls needed?
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-28 20:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 19:12 Jack Steiner
2008-03-28 20:15 ` Ingo Molnar [this message]
2008-03-28 20:24 ` Jack Steiner
2008-03-28 20:45 ` Ingo Molnar
2008-03-28 21:08 ` Jack Steiner
2008-03-30 23:22 ` Yinghai Lu
2008-03-31 1:33 ` Yinghai Lu
2008-03-31 2:12 ` Jack Steiner
2008-03-31 2:23 ` Yinghai Lu
2008-03-31 2:26 ` Jack Steiner
2008-03-31 2:29 ` Yinghai Lu
2008-03-31 2:40 ` Jack Steiner
2008-03-31 2:06 ` Jack Steiner
2008-03-31 2:13 ` Yinghai Lu
2008-03-31 2:23 ` Jack Steiner
2008-03-31 2:27 ` Yinghai Lu
2008-03-31 2:31 ` Jack Steiner
2008-03-31 2:02 ` [PATCH 8/8] x86_64: V2 " Jack Steiner
2008-03-31 13:07 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080328201532.GB26555@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox