From: Nishanth Aravamudan <nacc@us.ibm.com>
To: torvalds@linux-foundation.org
Cc: akpm@linux-foundation.org, agl@us.ibm.com, apw@shadowen.org,
mel@csn.ul.ie, linux-mm@kvack.org
Subject: [PATCH 1/2] hugetlb: indicate surplus huge page counts in per-node meminfo
Date: Wed, 26 Mar 2008 14:37:53 -0700 [thread overview]
Message-ID: <20080326213753.GE14331@us.ibm.com> (raw)
Currently we show the surplus hugetlb pool state in /proc/meminfo, but
not in the per-node meminfo files, even though we track the information
on a per-node basis. Printing it there can help track down dynamic pool
bugs including the one in the follow-on patch.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
---
This would be nice to have this late in the 2.6.25 cycle, but should not
block the follow-on patch from getting merged.
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index ecaeedb..548a75d 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -719,9 +719,11 @@ int hugetlb_report_node_meminfo(int nid, char *buf)
{
return sprintf(buf,
"Node %d HugePages_Total: %5u\n"
- "Node %d HugePages_Free: %5u\n",
+ "Node %d HugePages_Free: %5u\n"
+ "Node %d HugePages_Surp: %5u\n",
nid, nr_huge_pages_node[nid],
- nid, free_huge_pages_node[nid]);
+ nid, free_huge_pages_node[nid],
+ nid, surplus_huge_pages_node[nid]);
}
#ifdef CONFIG_NUMA
--
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2008-03-26 21:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 21:37 Nishanth Aravamudan [this message]
2008-03-26 21:40 ` [PATCH 2/2] hugetlb: fix potential livelock in return_unused_surplus_hugepages() Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080326213753.GE14331@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=agl@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox