From: Ingo Molnar <mingo@elte.hu>
To: Jack Steiner <steiner@sgi.com>
Cc: tglx@linutronix.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 8/8] x86_64: Support for new UV apic
Date: Tue, 25 Mar 2008 15:30:59 +0100 [thread overview]
Message-ID: <20080325143059.GB11323@elte.hu> (raw)
In-Reply-To: <20080324182122.GA28327@sgi.com>
* Jack Steiner <steiner@sgi.com> wrote:
> Index: linux/arch/x86/kernel/genapic_64.c
> @@ -69,7 +73,16 @@ void send_IPI_self(int vector)
>
> unsigned int get_apic_id(void)
> {
> - return (apic_read(APIC_ID) >> 24) & 0xFFu;
> + unsigned int id;
> +
> + preempt_disable();
> + id = apic_read(APIC_ID);
> + if (uv_system_type >= UV_X2APIC)
> + id |= __get_cpu_var(x2apic_extra_bits);
> + else
> + id = (id >> 24) & 0xFFu;;
> + preempt_enable();
> + return id;
dont we want to put get_apic_id() into struct genapic instead? We
already have ID management there.
also, we want to unify 32-bit and 64-bit genapic code and just have
genapic all across x86.
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-25 14:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 18:21 Jack Steiner
2008-03-25 10:25 ` Andi Kleen
2008-03-25 17:56 ` Jack Steiner
2008-03-25 18:06 ` Andi Kleen
2008-03-26 2:23 ` Jeremy Fitzhardinge
2008-03-26 3:22 ` Glauber Costa
2008-03-26 7:29 ` Ingo Molnar
2008-03-26 7:38 ` Ingo Molnar
2008-03-30 20:23 ` Yinghai Lu
2008-03-30 21:03 ` Jack Steiner
2008-03-30 21:18 ` Andi Kleen
2008-03-30 23:29 ` Yinghai Lu
2008-03-31 2:18 ` Jack Steiner
2008-03-31 2:20 ` Yinghai Lu
2008-03-31 12:33 ` Ingo Molnar
2008-03-31 12:52 ` Andi Kleen
2008-03-31 18:42 ` Yinghai Lu
2008-03-31 6:48 ` Andi Kleen
2008-03-25 14:30 ` Ingo Molnar [this message]
2008-03-25 16:31 ` Jack Steiner
2008-03-26 3:24 ` Glauber Costa
2008-03-30 20:41 ` Yinghai Lu
2008-03-30 21:08 ` Jack Steiner
2008-03-30 23:24 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080325143059.GB11323@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox