From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH] fix spurious EBUSY on memory cgroup removal In-Reply-To: Your message of "Mon, 24 Mar 2008 22:53:09 -0700" <20080324225309.0a1ab8ec.akpm@linux-foundation.org> References: <20080324225309.0a1ab8ec.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Message-Id: <20080325062853.49EE11E931B@siro.lan> Date: Tue, 25 Mar 2008 15:28:53 +0900 (JST) From: yamamoto@valinux.co.jp (YAMAMOTO Takashi) Sender: owner-linux-mm@kvack.org Return-Path: To: akpm@linux-foundation.org Cc: containers@lists.osdl.org, linux-mm@kvack.org, minoura@valinux.co.jp, balbir@linux.vnet.ibm.com List-ID: > On Tue, 25 Mar 2008 14:47:13 +0900 (JST) yamamoto@valinux.co.jp (YAMAMOTO Takashi) wrote: > > > [ resending with To: akpm. Andrew, can you include this in -mm tree? ] > > Shouldn't it be in 2.6.25? yes, probably. (i'm not sure about linux development model.) YAMAMOTO Takashi > > > hi, > > > > the following patch is to fix spurious EBUSY on cgroup removal. > > > > YAMAMOTO Takashi > > > > > > call mm_free_cgroup earlier. > > otherwise a reference due to lazy mm switching can prevent cgroup removal. > > > > Signed-off-by: YAMAMOTO Takashi > > Acked-by: Balbir Singh > > --- > > > > --- linux-2.6.24-rc8-mm1/kernel/fork.c.BACKUP 2008-01-23 14:43:29.000000000 +0900 > > +++ linux-2.6.24-rc8-mm1/kernel/fork.c 2008-01-31 17:26:31.000000000 +0900 > > @@ -393,7 +393,6 @@ void __mmdrop(struct mm_struct *mm) > > { > > BUG_ON(mm == &init_mm); > > mm_free_pgd(mm); > > - mm_free_cgroup(mm); > > destroy_context(mm); > > free_mm(mm); > > } > > @@ -415,6 +414,7 @@ void mmput(struct mm_struct *mm) > > spin_unlock(&mmlist_lock); > > } > > put_swap_token(mm); > > + mm_free_cgroup(mm); > > mmdrop(mm); > > } > > } > _______________________________________________ > Containers mailing list > Containers@lists.linux-foundation.org > https://lists.linux-foundation.org/mailman/listinfo/containers -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org