From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
To: nitingupta910@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/6] compcache: block device - internal defs
Date: Mon, 24 Mar 2008 17:25:59 +0100 [thread overview]
Message-ID: <200803241725.59726.m.kozlowski@tuxland.pl> (raw)
In-Reply-To: <200803242033.30782.nitingupta910@gmail.com>
Hi Nitin,
> +#define K(x) ((x) >> 10)
> +#define KB(x) ((x) << 10)
Hm. These look cryptic unless you remember what they do.
Could have better names?
> +#define CC_DEBUG2((fmt,arg...) \
> + printk(KERN_DEBUG C fmt,##arg)
Unbalanced parenthesis.
Just my 0.05zl.
Mariusz
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-24 16:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 15:03 Nitin Gupta
2008-03-24 16:05 ` Will Newton
2008-03-24 17:50 ` Nitin Gupta
2008-03-24 20:36 ` Will Newton
2008-03-24 20:39 ` Nitin Gupta
2008-03-24 16:25 ` Mariusz Kozlowski [this message]
2008-03-24 17:39 ` Nitin Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803241725.59726.m.kozlowski@tuxland.pl \
--to=m.kozlowski@tuxland.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nitingupta910@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox