From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 18 Mar 2008 16:46:10 +0000 From: Mel Gorman Subject: Re: [PATCH] [13/18] Add support to allocate hugepages of different size with hugepages=... Message-ID: <20080318164610.GO23866@csn.ul.ie> References: <20080317258.659191058@firstfloor.org> <20080317015827.15E811B41E0@basil.firstfloor.org> <20080318163225.GM23866@csn.ul.ie> <20080318164550.GF11966@one.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20080318164550.GF11966@one.firstfloor.org> Sender: owner-linux-mm@kvack.org Return-Path: To: Andi Kleen Cc: linux-kernel@vger.kernel.org, pj@sgi.com, linux-mm@kvack.org, nickpiggin@yahoo.com.au List-ID: On (18/03/08 17:45), Andi Kleen didst pronounce: > > hmm, it's not very clear to me how hugetlb_init_hstate() would get > > called twice for the same hstate. Should it be VM_BUG_ON() if a hstate > > It is called from a __setup function and the user can specify them multiple > times. Also when the user specified the HPAGE_SIZE already and it got set up > it should not be called again. > Ok, that is a fair explanation. Thanks. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org