From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: apw@shadowen.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>,
linux-mm@kvack.org
Subject: Re: [patch 0/9] Page flags V3: Cleanup and reorg
Date: Mon, 10 Mar 2008 21:50:03 -0700 [thread overview]
Message-ID: <20080310215003.8622e6b8.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080308001850.306617873@sgi.com>
On Fri, 07 Mar 2008 16:18:50 -0800 Christoph Lameter <clameter@sgi.com> wrote:
> A set of patches that attempts to improve page flag handling.
First darn thing I tried was i386 allnoconfig and it goes splat.
In file included from include/linux/mm.h:192,
from kernel/bounds.c:8:
include/linux/page-flags.h: In function 'PageHighMem':
include/linux/page-flags.h:180: error: implicit declaration of function 'page_zone'
There's also a parenthesis mismatch so it looks like it was neither
compile-time nor runtime tested on i386. Sorry, but I don't have the time
to be the first one to try this out.
To fix this page-flags.h needs to include mm.h, but mm.h includes
page-flags.h. Making PageHighMem a macro would be the expedient fix.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next parent reply other threads:[~2008-03-11 4:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080308001850.306617873@sgi.com>
2008-03-11 4:50 ` Andrew Morton [this message]
[not found] <20080318181957.138598511@sgi.com>
2008-03-28 9:08 ` Andrew Morton
[not found] <20080401200019.47892504.akpm@linux-foundation.org>
[not found] ` <Pine.LNX.4.64.0804021026400.26938@schroedinger.engr.sgi.com>
[not found] ` <Pine.LNX.4.64.0804022125001.1684@schroedinger.engr.sgi.com>
[not found] ` <20080402.222542.106676535.davem@davemloft.net>
[not found] ` <Pine.LNX.4.64.0804031149060.7108@schroedinger.engr.sgi.com>
2008-04-10 17:33 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080310215003.8622e6b8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=clameter@sgi.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox