linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jens Osterkamp <Jens.Osterkamp@gmx.de>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-mm@kvack.org
Subject: Re: [BUG] in 2.6.25-rc3 with 64k page size and SLUB_DEBUG_ON
Date: Thu, 6 Mar 2008 22:07:34 +0100	[thread overview]
Message-ID: <200803062207.37654.Jens.Osterkamp@gmx.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0803061151590.14140@schroedinger.engr.sgi.com>

[-- Attachment #1: Type: text/plain, Size: 1919 bytes --]


Hi,

> > Call Trace:
> > [c00000003c187b68] [c00000000000f140] .show_stack+0x70/0x1bc (unreliable)
> > [c00000003c187c18] [c000000000052d0c] .__schedule_bug+0x64/0x80
> > [c00000003c187ca8] [c00000000036fa84] .schedule+0xc4/0x6b0
> > [c00000003c187d98] [c0000000003702d0] .schedule_timeout+0x3c/0xe8
> > [c00000003c187e68] [c00000000036f82c] .wait_for_common+0x150/0x22c
> > [c00000003c187f28] [c000000000074868] .kthreadd+0x12c/0x1f0
> > [c00000003c187fd8] [c000000000024864] .kernel_thread+0x4c/0x68
> 
> But nothing slub wise here...

I had earlier biesected this to the following commit, should have mentioned that,
sorry !

commit f0630fff54a239efbbd89faf6a62da071ef1ff78
Author: Christoph Lameter <clameter@sgi.com>
Date:   Sun Jul 15 23:38:14 2007 -0700

    SLUB: support slub_debug on by default

    [...]

> Could be the result of fallback under debug?? Looks like there is a hole 
> in the fallback logic. But this could be something completely different.

What do you mean by fallback ?

> If this is slub related then we may not be reenabling interrupt somewhere 
> if debug is on.
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index 96d63eb..6d0a103 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1536,8 +1536,14 @@ new_slab:
>  	 * That is only possible if certain conditions are met that are being
>  	 * checked when a slab is created.
>  	 */
> -	if (!(gfpflags & __GFP_NORETRY) && (s->flags & __PAGE_ALLOC_FALLBACK))
> -		return kmalloc_large(s->objsize, gfpflags);
> +	if (!(gfpflags & __GFP_NORETRY) && (s->flags & __PAGE_ALLOC_FALLBACK)) {
> +		if (gfpflags & __GFP_WAIT)
> +			local_irq_enable();
> +		object =  kmalloc_large(s->objsize, gfpflags);
> +		if (gfpflags & __GFP_WAIT)
> +			local_irq_disable();
> +		return object;
> +	}
>  
>  	return NULL;
>  debug:

I just tried the patch, but the problem is still there...

Gruß,
	Jens

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2008-03-06 21:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 13:47 Jens Osterkamp
2008-03-06 19:55 ` Christoph Lameter
2008-03-06 21:07   ` Jens Osterkamp [this message]
2008-03-06 21:50     ` Christoph Lameter
2008-03-06 21:52       ` Jens Osterkamp
2008-03-06 21:56         ` Christoph Lameter
2008-03-06 22:00           ` Pekka Enberg
2008-03-06 22:04             ` Pekka Enberg
2008-03-06 22:07             ` Jens Osterkamp
2008-03-06 22:20               ` Christoph Lameter
2008-03-06 22:24                 ` Pekka Enberg
2008-03-07 12:20                   ` Jens Osterkamp
2008-03-07 12:40                     ` Pekka J Enberg
2008-03-07 12:44                       ` Pekka J Enberg
2008-03-07 22:18                         ` Jens Osterkamp
2008-03-07 22:30                       ` Jens Osterkamp
2008-03-07 22:59                         ` Christoph Lameter
2008-03-12 15:19                           ` Jens Osterkamp
2008-03-12 23:34                             ` Christoph Lameter
2008-03-18 16:44                               ` Jens Osterkamp
2008-03-18 17:45                                 ` Christoph Lameter
2008-03-18 17:51                                   ` Pekka Enberg
2008-03-06 22:25                 ` Jens Osterkamp
2008-03-07 22:09                 ` Jens Osterkamp
2008-03-06 22:21           ` Jens Osterkamp
2008-03-06 21:27 ` Pekka Enberg
2008-03-06 21:45   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803062207.37654.Jens.Osterkamp@gmx.de \
    --to=jens.osterkamp@gmx.de \
    --cc=clameter@sgi.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox