From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Rick van Rein <rick@vanrein.org>
Cc: kosaki.motohiro@jp.fujitsu.com,
KOSAKI Motohiro <m-kosaki@ceres.dti.ne.jp>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.24] mm: BadRAM support for broken memory
Date: Mon, 03 Mar 2008 12:21:27 +0900 [thread overview]
Message-ID: <20080303121335.1E7B.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <20080302174235.GA26902@phantom.vanrein.org>
Hi Rick
> > > +#define PG_badram 20 /* BadRam page */
> >
> > some architecture use PG_reserved for treat bad memory.
> > Why do you want introduce new page flag?
>
> It is clearer to properly name a flag, I suppose.
> Is the use that you are mentioning the intended, and only use of the flag?
> If not, I think it is clearer to use a separate flag instead of overloading
> one.
hmmm
unfortunately flag bit of struct page is very valuable resource
rather than diamond on current implementaion ;-)
if you can change to no introduce new page flag,
IMHO merge to mainline dramatically become easy.
> > for show_mem() improvement?
>
> For code clarity.
agreed with your code is clarify. but...
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-03 3:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-02 13:42 Rick van Rein
2008-03-02 17:01 ` KOSAKI Motohiro
2008-03-02 17:42 ` Rick van Rein
2008-03-03 3:21 ` KOSAKI Motohiro [this message]
2008-03-03 5:32 ` Nick Piggin
2008-03-03 7:14 ` KOSAKI Motohiro
2008-03-03 7:35 ` Nick Piggin
2008-03-03 9:49 ` KOSAKI Motohiro
2008-03-03 9:58 ` KAMEZAWA Hiroyuki
2008-03-03 17:38 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080303121335.1E7B.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m-kosaki@ceres.dti.ne.jp \
--cc=rick@vanrein.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox