From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 29 Feb 2008 15:19:39 +0900 From: KOSAKI Motohiro Subject: trivial clean up to zlc_setup Message-Id: <20080229151057.66ED.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Lee Schermerhorn , Paul Jackson , linux-mm@kvack.org, LKML Cc: kosaki.motohiro@jp.fujitsu.com List-ID: Hi I found very small bug during review mel's 2 zonelist patch series. this patch is trivial clean up. jiffies subtraction may cause overflow problem. it shold be used time_after(). Thanks. Signed-off-by: KOSAKI Motohiro CC: Lee Schermerhorn CC: Paul Jackson --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/mm/page_alloc.c =================================================================== --- a/mm/page_alloc.c 2008-02-18 17:17:25.000000000 +0900 +++ b/mm/page_alloc.c 2008-02-29 15:17:03.000000000 +0900 @@ -1294,7 +1294,7 @@ static nodemask_t *zlc_setup(struct zone if (!zlc) return NULL; - if (jiffies - zlc->last_full_zap > 1 * HZ) { + if (time_after(jiffies, zlc->last_full_zap + HZ)) { bitmap_zero(zlc->fullzones, MAX_ZONES_PER_ZONELIST); zlc->last_full_zap = jiffies; } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org