From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: David Rientjes <rientjes@google.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Rik van Riel <riel@redhat.com>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
Nick Piggin <npiggin@suse.de>
Subject: Re: [RFC][PATCH] page reclaim throttle take2
Date: Wed, 27 Feb 2008 16:51:39 +0900 [thread overview]
Message-ID: <20080227165139.18e5933e.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0802262315030.11433@chino.kir.corp.google.com>
On Tue, 26 Feb 2008 23:19:08 -0800 (PST)
David Rientjes <rientjes@google.com> wrote:
> My suggestion is merely to make the number of concurrent page reclaim
> threads be a function of how many online cpus there are. Threads can
> easily be added or removed for cpu hotplug events by callback functions.
>
> That's different than allowing users to change the number of threads with
> yet another sysctl. Unless there are situations that can be presented
> where tuning the number of threads is advantageous to reduce lock
> contention, for example, and not simply working around other VM problems,
> then I see no point for an additional sysctl.
>
> So my suggestion is to implement this in terms of
> CONFIG_NUM_RECLAIM_THREADS_PER_CPU and add callback functions for cpu
> hotplug events that add or remove this number of threads.
>
Hmm, but kswapd, which is main worker of page reclaiming, is per-node.
And reclaim is done based on zone.
per-zone/per-node throttling seems to make sense.
I know his environment has 4cpus per node but throttle to 3 was the best
number in his measurement. Then it seems num-per-cpu is excessive.
(At least, ratio(%) is better.)
When zone-reclaiming is improved to be scale well, we'll have to change
this throttle.
BTW, could someone try his patch on x86_64/ppc ?
I'd like to see how contention is heavy on other machines.
Thanks,
-kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-02-27 7:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 2:32 KOSAKI Motohiro
2008-02-26 21:18 ` Peter Zijlstra
2008-02-27 0:50 ` KAMEZAWA Hiroyuki
2008-02-27 4:26 ` KOSAKI Motohiro
2008-02-27 4:27 ` Balbir Singh
2008-02-27 4:45 ` KOSAKI Motohiro
2008-02-27 5:00 ` KAMEZAWA Hiroyuki
2008-02-27 5:04 ` KOSAKI Motohiro
2008-02-27 5:03 ` Balbir Singh
2008-02-27 5:13 ` KOSAKI Motohiro
2008-02-27 5:19 ` David Rientjes
2008-02-27 5:33 ` KOSAKI Motohiro
2008-02-27 5:47 ` David Rientjes
2008-02-27 5:48 ` Balbir Singh
2008-02-27 6:09 ` David Rientjes
2008-02-27 7:10 ` KOSAKI Motohiro
2008-02-27 7:19 ` David Rientjes
2008-02-27 7:51 ` KAMEZAWA Hiroyuki [this message]
2008-02-27 7:56 ` David Rientjes
2008-02-27 8:09 ` KAMEZAWA Hiroyuki
2008-02-27 15:30 ` Rik van Riel
2008-02-27 7:59 ` Balbir Singh
2008-02-27 8:47 ` David Rientjes
2008-02-27 9:01 ` Balbir Singh
2008-02-27 9:44 ` Peter Zijlstra
2008-02-27 6:52 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080227165139.18e5933e.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=a.p.zijlstra@chello.nl \
--cc=balbir@linux.vnet.ibm.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox