From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 27 Feb 2008 08:41:56 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH 04/15] memcg: when do_swap's do_wp_page fails Message-Id: <20080227084156.fca91c86.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Hugh Dickins Cc: Balbir Singh , Andrew Morton , Hirokazu Takahashi , YAMAMOTO Takashi , Nick Piggin , linux-mm@kvack.org List-ID: On Mon, 25 Feb 2008 23:38:02 +0000 (GMT) Hugh Dickins wrote: > Don't uncharge when do_swap_page's call to do_wp_page fails: the page which > was charged for is there in the pagetable, and will be correctly uncharged > when that area is unmapped - it was only its COWing which failed. > > And while we're here, remove earlier XXX comment: yes, OR in do_wp_page's > return value (maybe VM_FAULT_WRITE) with do_swap_page's there; but if it > fails, mask out success bits, which might confuse some arches e.g. sparc. > > Signed-off-by: Hugh Dickins Acked-by: KAMEZAWA Hiroyuki -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org