From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.18.234]) by e23smtp04.au.ibm.com (8.13.1/8.13.1) with ESMTP id m1QG7vZQ029572 for ; Wed, 27 Feb 2008 03:07:57 +1100 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m1QG8K4x2474162 for ; Wed, 27 Feb 2008 03:08:20 +1100 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m1QG8K3X031046 for ; Wed, 27 Feb 2008 03:08:20 +1100 Date: Tue, 26 Feb 2008 21:32:49 +0530 From: Balbir Singh Subject: Re: [PATCH 03/15] memcg: page_cache_release not __free_page Message-ID: <20080226160248.GB25074@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org Return-Path: To: Hugh Dickins Cc: Andrew Morton , KAMEZAWA Hiroyuki , Hirokazu Takahashi , YAMAMOTO Takashi , linux-mm@kvack.org List-ID: * Hugh Dickins [2008-02-25 23:37:05]: > There's nothing wrong with mem_cgroup_charge failure in do_wp_page and > do_anonymous page using __free_page, but it does look odd when nearby > code uses page_cache_release: use that instead (while turning a blind > eye to ancient inconsistencies of page_cache_release versus put_page). > > Signed-off-by: Hugh Dickins Acked-by: Balbir Singh -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org