From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e6.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m1711Pm3012917 for ; Wed, 6 Feb 2008 20:01:25 -0500 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m170xVmn238138 for ; Wed, 6 Feb 2008 19:59:31 -0500 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m170xVaO007804 for ; Wed, 6 Feb 2008 19:59:31 -0500 Date: Wed, 6 Feb 2008 16:59:24 -0800 From: Nishanth Aravamudan Subject: Re: [PATCH 2/3] hugetlb: add per-node nr_hugepages sysfs attribute Message-ID: <20080207005924.GB14137@us.ibm.com> References: <20080206231558.GI3477@us.ibm.com> <20080206231845.GJ3477@us.ibm.com> <20080207000328.GD16116@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080207000328.GD16116@kroah.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Greg KH Cc: wli@holomorphy.com, agl@us.ibm.com, lee.schermerhorn@hp.com, linux-mm@kvack.org List-ID: On 06.02.2008 [16:03:28 -0800], Greg KH wrote: > On Wed, Feb 06, 2008 at 03:18:45PM -0800, Nishanth Aravamudan wrote: > > hugetlb: add per-node nr_hugepages sysfs attribute > > > > Allow specifying the number of hugepages to allocate on a particular > > node. Our current global sysctl will try its best to put hugepages > > equally on each node, but htat may not always be desired. This allows > > the admin to control the layout of hugepage allocation at a finer level > > (while not breaking the existing interface). Add callbacks in the sysfs > > node registration and unregistration functions into hugetlb to add the > > nr_hugepages attribute, which is a no-op if !NUMA or !HUGETLB. > > > > Signed-off-by: Nishanth Aravamudan > > > > --- > > Greg, do I need to add documentation for this sysfs attribute to > > Documentation/ABI? > > Yes, please. Ok, thanks. I'll submit a follow-on patch. > > I'm not sure if I should just add a file in testing/ for just this > > attribute or should defer and create documentation for all of the > > /sys/devices/system/node information? > > How about both for this one, and the existing ones? That would be > best. Sorry, that's what I meant (documenting existing interface and adding this to that documentation). I'll probably do it in a separate series. Thanks, Nish -- Nishanth Aravamudan IBM Linux Technology Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org