Re: [PATCH 2/3] hugetlb: add per-node nr_hugepages sysfs attribute

[Nishanth Aravamudan <nacc@us.ibm.com>]

On 06.02.2008 [16:03:28 -0800], Greg KH wrote:
> On Wed, Feb 06, 2008 at 03:18:45PM -0800, Nishanth Aravamudan wrote:
> > hugetlb: add per-node nr_hugepages sysfs attribute
> > 
> > Allow specifying the number of hugepages to allocate on a particular
> > node. Our current global sysctl will try its best to put hugepages
> > equally on each node, but htat may not always be desired. This allows
> > the admin to control the layout of hugepage allocation at a finer level
> > (while not breaking the existing interface).  Add callbacks in the sysfs
> > node registration and unregistration functions into hugetlb to add the
> > nr_hugepages attribute, which is a no-op if !NUMA or !HUGETLB.
> > 
> > Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> > 
> > ---
> > Greg, do I need to add documentation for this sysfs attribute to
> > Documentation/ABI?
> 
> Yes, please.

Ok, thanks. I'll submit a follow-on patch.

> > I'm not sure if I should just add a file in testing/ for just this
> > attribute or should defer and create documentation for all of the
> > /sys/devices/system/node information?
> 
> How about both for this one, and the existing ones?  That would be
> best.

Sorry, that's what I meant (documenting existing interface and adding
this to that documentation). I'll probably do it in a separate series.

Thanks,
Nish

-- 
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>