From: Christoph Hellwig <hch@infradead.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Anton Salikhmetov <salikhmetov@gmail.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
linux-mm@kvack.org, jakob@unthought.net,
linux-kernel@vger.kernel.org, valdis.kletnieks@vt.edu,
riel@redhat.com, ksm@42.dk, staubach@redhat.com,
jesper.juhl@gmail.com, torvalds@linux-foundation.org,
akpm@linux-foundation.org, protasnb@gmail.com, miklos@szeredi.hu
Subject: Re: [PATCH 1/2] Massive code cleanup of sys_msync()
Date: Tue, 15 Jan 2008 19:32:04 +0000 [thread overview]
Message-ID: <20080115193204.GA25866@infradead.org> (raw)
In-Reply-To: <1200425328.26045.39.camel@twins>
On Tue, Jan 15, 2008 at 08:28:48PM +0100, Peter Zijlstra wrote:
> Notice that error is already -EINVAL, so a simple goto should suffice.
Yes, for the start of the function you can basically leave it as-is.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-01-15 19:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 16:02 [PATCH 0/2] Updating ctime and mtime for memory-mapped files [try #4] Anton Salikhmetov
2008-01-15 16:02 ` [PATCH 1/2] Massive code cleanup of sys_msync() Anton Salikhmetov
2008-01-15 17:57 ` Christoph Hellwig
2008-01-15 19:02 ` Anton Salikhmetov
2008-01-15 19:10 ` Randy Dunlap
2008-01-15 19:26 ` Anton Salikhmetov
2008-01-15 19:28 ` Peter Zijlstra
2008-01-15 19:32 ` Christoph Hellwig [this message]
2008-01-15 20:12 ` Anton Salikhmetov
2008-01-15 20:46 ` Matt Mackall
2008-01-15 21:06 ` Randy Dunlap
2008-01-15 16:02 ` [PATCH 2/2] Updating ctime and mtime at syncing Anton Salikhmetov
[not found] ` <1200414911.26045.32.camel@twins>
2008-01-15 17:18 ` Anton Salikhmetov
2008-01-15 19:30 ` Peter Zijlstra
2008-01-15 18:04 ` Christoph Hellwig
2008-01-15 19:04 ` Anton Salikhmetov
2008-01-15 20:27 ` [PATCH 0/2] Updating ctime and mtime for memory-mapped files [try #4] Miklos Szeredi
2008-01-15 20:32 ` Peter Zijlstra
2008-01-15 20:40 ` Miklos Szeredi
2008-01-15 22:15 ` Anton Salikhmetov
-- strict thread matches above, loose matches on Subject: below --
2008-01-13 4:39 [PATCH 0/2] yet another attempt to fix the ctime and mtime issue Anton Salikhmetov
2008-01-13 4:39 ` [PATCH 1/2] massive code cleanup of sys_msync() Anton Salikhmetov
2008-01-13 4:46 ` Rik van Riel
2008-01-14 10:49 ` Miklos Szeredi
2008-01-14 11:56 ` Anton Salikhmetov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080115193204.GA25866@infradead.org \
--to=hch@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=jakob@unthought.net \
--cc=jesper.juhl@gmail.com \
--cc=ksm@42.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
--cc=protasnb@gmail.com \
--cc=randy.dunlap@oracle.com \
--cc=riel@redhat.com \
--cc=salikhmetov@gmail.com \
--cc=staubach@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox