From: Andi Kleen <ak@suse.de>
To: travis@sgi.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <clameter@sgi.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>,
tglx@linutronix.de, mingo@redhat.com
Subject: Re: [PATCH 05/10] x86_64: Use generic percpu
Date: Fri, 28 Dec 2007 13:54:51 +0100 [thread overview]
Message-ID: <200712281354.52453.ak@suse.de> (raw)
In-Reply-To: <20071228001047.556634000@sgi.com>
On Friday 28 December 2007 01:10:51 travis@sgi.com wrote:
> x86_64 provides an optimized way to determine the local per cpu area
> offset through the pda and determines the base by accessing a remote
> pda.
And? The rationale for this patch seems to be incomplete.
As far as I can figure out you're replacing an optimized percpu
implementation which a dumber generic one. Which needs
at least some description why.
If the generic one is now as good or better than the
specific one that might be ok, but that should be somewhere
in the description.
Also for such changes .text size comparisons before/after
are a good idea.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-12-28 12:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-28 0:10 [PATCH 00/10] percpu: Per cpu code simplification V2 travis
2007-12-28 0:10 ` [PATCH 01/10] percpu: Use a kconfig variable to signal arch specific percpu setup travis
2007-12-28 0:15 ` David Miller, travis
2007-12-28 0:10 ` [PATCH 02/10] percpu: Move arch XX_PER_CPU_XX definitions into linux/percpu.h travis
2007-12-28 0:16 ` David Miller, travis
2007-12-28 0:10 ` [PATCH 03/10] percpu: Make the asm-generic/percpu.h more "generic" travis
2007-12-28 0:18 ` David Miller, travis
2007-12-28 0:10 ` [PATCH 04/10] x86_32: Use generic percpu.h travis
2007-12-28 0:10 ` [PATCH 05/10] x86_64: Use generic percpu travis
2007-12-28 12:54 ` Andi Kleen [this message]
2007-12-28 22:05 ` Mike Travis
2007-12-29 1:55 ` Andi Kleen
2007-12-31 16:19 ` Mike Travis
2008-01-02 20:58 ` Christoph Lameter
2007-12-30 14:18 ` Ingo Molnar
2007-12-31 16:21 ` Mike Travis
2007-12-31 17:10 ` Mike Travis
2008-01-01 19:17 ` Ingo Molnar
2008-01-02 21:04 ` Christoph Lameter
2008-01-02 21:33 ` Ingo Molnar
2008-01-02 20:59 ` Christoph Lameter
2008-01-02 20:55 ` Christoph Lameter
2007-12-28 0:10 ` [PATCH 06/10] s390: " travis
2007-12-28 0:10 ` [PATCH 07/10] Powerpc: Use generic per cpu travis
2007-12-28 0:16 [PATCH 00/10] percpu: Per cpu code simplification V2 travis
2007-12-28 0:16 ` [PATCH 05/10] x86_64: Use generic percpu travis
2008-01-08 2:11 [PATCH 00/10] percpu: Per cpu code simplification V3 travis
2008-01-08 2:11 ` [PATCH 05/10] x86_64: Use generic percpu travis
2008-01-08 21:10 [PATCH 00/10] percpu: Per cpu code simplification V4 travis
2008-01-08 21:10 ` [PATCH 05/10] x86_64: Use generic percpu travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712281354.52453.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox