linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dhaval Giani <dhaval@linux.vnet.ibm.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	htejun@gmail.com, gregkh@suse.de,
	Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
	Balbir Singh <balbir@in.ibm.com>,
	maneesh@linux.vnet.ibm.com, lkml <linux-kernel@vger.kernel.org>,
	stable@kernel.org, linux-mm@kvack.org
Subject: Re: 2.6.22-stable causes oomkiller to be invoked
Date: Fri, 21 Dec 2007 10:15:08 +0530	[thread overview]
Message-ID: <20071221044508.GA11996@linux.vnet.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0712171222470.29500@schroedinger.engr.sgi.com>

> > It was just
> > 
> > 	while echo ; do cat /sys/kernel/<some file> ; done
> > 
> > it's all in the email threads somewhere..
> 
> The patch that was posted in the thread that I mentioned earlier is here. 
> I ran the test for 15 minutes and things are still fine.
> 
> 
> 
> quicklist: Set tlb->need_flush if pages are remaining in quicklist 0
> 
> This ensures that the quicklists are drained. Otherwise draining may only 
> occur when the processor reaches an idle state.
> 

Hi Christoph,

No, it does not stop the oom I am seeing here.

Thanks,

> Signed-off-by: Christoph Lameter <clameter@sgi.com>
> 
> Index: linux-2.6/include/asm-generic/tlb.h
> ===================================================================
> --- linux-2.6.orig/include/asm-generic/tlb.h	2007-12-13 14:45:38.000000000 -0800
> +++ linux-2.6/include/asm-generic/tlb.h	2007-12-13 14:51:07.000000000 -0800
> @@ -14,6 +14,7 @@
>  #define _ASM_GENERIC__TLB_H
> 
>  #include <linux/swap.h>
> +#include <linux/quicklist.h>
>  #include <asm/pgalloc.h>
>  #include <asm/tlbflush.h>
> 
> @@ -85,6 +86,9 @@ tlb_flush_mmu(struct mmu_gather *tlb, un
>  static inline void
>  tlb_finish_mmu(struct mmu_gather *tlb, unsigned long start, unsigned long end)
>  {
> +#ifdef CONFIG_QUICKLIST
> +	tlb->need_flush += &__get_cpu_var(quicklist)[0].nr_pages != 0;
> +#endif
>  	tlb_flush_mmu(tlb, start, end);
> 
>  	/* keep the page table cache within bounds */

-- 
regards,
Dhaval

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2007-12-21  4:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071213132326.GC16905@linux.vnet.ibm.com>
     [not found] ` <20071213151847.GB5676@linux.vnet.ibm.com>
     [not found]   ` <20071213162936.GA7635@suse.de>
     [not found]     ` <20071213164658.GA30865@linux.vnet.ibm.com>
     [not found]       ` <20071213175423.GA2977@linux.vnet.ibm.com>
     [not found]         ` <476295FF.1040202@gmail.com>
     [not found]           ` <20071214154711.GD23670@linux.vnet.ibm.com>
     [not found]             ` <4762A721.7080400@gmail.com>
     [not found]               ` <20071214161637.GA2687@linux.vnet.ibm.com>
     [not found]                 ` <20071214095023.b5327703.akpm@linux-foundation.org>
     [not found]                   ` <20071214182802.GC2576@linux.vnet.ibm.com>
2007-12-14 23:05                     ` Andrew Morton
2007-12-15  3:52                       ` Dhaval Giani
2007-12-15  6:00                         ` Andrew Morton
2007-12-15 10:44                           ` Dhaval Giani
     [not found]                             ` <20071217045904.GB31386@linux.vnet.ibm.com>
     [not found]                               ` <Pine.LNX.4.64.0712171143280.12871@schroedinger.engr.sgi.com>
     [not found]                                 ` <20071217120720.e078194b.akpm@linux-foundation.org>
     [not found]                                   ` <Pine.LNX.4.64.0712171222470.29500@schroedinger.engr.sgi.com>
2007-12-21  4:45                                     ` Dhaval Giani [this message]
2007-12-26 21:01                                       ` Christoph Lameter
     [not found]                                         ` <Pine.LNX.4.64.0712271119030.30555@schroedinger.engr.sgi.com>
2007-12-28 10:11                                           ` Dhaval Giani
2008-01-02 20:45                                             ` Christoph Lameter
2008-01-02 21:54                                               ` Christoph Lameter
2008-01-03  3:59                                                 ` Dhaval Giani
2008-01-03  4:16                                                   ` Dhaval Giani
2008-01-03 21:04                                                     ` Christoph Lameter
2008-01-07 20:04                                                       ` Christoph Lameter
2008-01-08  4:33                                                         ` Dhaval Giani
2007-12-30 14:01                                         ` Ingo Molnar
2007-12-30 19:24                                           ` Dhaval Giani
2008-01-02 20:48                                           ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071221044508.GA11996@linux.vnet.ibm.com \
    --to=dhaval@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@in.ibm.com \
    --cc=clameter@sgi.com \
    --cc=gregkh@suse.de \
    --cc=htejun@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maneesh@linux.vnet.ibm.com \
    --cc=stable@kernel.org \
    --cc=vatsa@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox