From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 3 Dec 2007 18:36:39 +0900 From: KAMEZAWA Hiroyuki Subject: [RFC][for -mm] memory controller enhancements for reclaiming take2 [2/8] add BUG_ON() in mem_cgroup_zoneinfo Message-Id: <20071203183639.48a4b1f3.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20071203183355.0061ddeb.kamezawa.hiroyu@jp.fujitsu.com> References: <20071203183355.0061ddeb.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "containers@lists.osdl.org" , Andrew Morton , "balbir@linux.vnet.ibm.com" , "yamamoto@valinux.co.jp" , "riel@redhat.com" , xemul@openvz.org List-ID: This should be BUG_ON(). I misunderstood initialization path. Signed-off-by: KAMEZAWA Hiroyuki mm/memcontrol.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux-2.6.24-rc3-mm2/mm/memcontrol.c =================================================================== --- linux-2.6.24-rc3-mm2.orig/mm/memcontrol.c +++ linux-2.6.24-rc3-mm2/mm/memcontrol.c @@ -206,8 +206,7 @@ static void mem_cgroup_charge_statistics static inline struct mem_cgroup_per_zone * mem_cgroup_zoneinfo(struct mem_cgroup *mem, int nid, int zid) { - if (!mem->info.nodeinfo[nid]) - return NULL; + BUG_ON(!mem->info.nodeinfo[nid]); return &mem->info.nodeinfo[nid]->zoneinfo[zid]; } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org