From: yamamoto@valinux.co.jp (YAMAMOTO Takashi)
To: kamezawa.hiroyu@jp.fujitsu.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
containers@lists.osdl.org, akpm@linux-foundation.org,
balbir@linux.vnet.ibm.com
Subject: Re: [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [3/10] per-zone active inactive counter
Date: Thu, 29 Nov 2007 12:19:37 +0900 (JST) [thread overview]
Message-ID: <20071129031937.3C86F1CFE80@siro.lan> (raw)
In-Reply-To: Your message of "Tue, 27 Nov 2007 12:00:48 +0900" <20071127120048.ef5f2005.kamezawa.hiroyu@jp.fujitsu.com>
> @@ -651,10 +758,11 @@
> /* Avoid race with charge */
> atomic_set(&pc->ref_cnt, 0);
> if (clear_page_cgroup(page, pc) == pc) {
> + int active;
> css_put(&mem->css);
> + active = pc->flags & PAGE_CGROUP_FLAG_ACTIVE;
> res_counter_uncharge(&mem->res, PAGE_SIZE);
> - list_del_init(&pc->lru);
> - mem_cgroup_charge_statistics(mem, pc->flags, false);
> + __mem_cgroup_remove_list(pc);
> kfree(pc);
> } else /* being uncharged ? ...do relax */
> break;
'active' seems unused.
YAMAMOTO Takashi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-11-29 3:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 2:55 [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [0/10] introduction KAMEZAWA Hiroyuki
2007-11-27 2:58 ` [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [1/10] add scan_global_lru macro KAMEZAWA Hiroyuki
2007-11-27 2:59 ` [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [2/10] nid/zid helper function for cgroup KAMEZAWA Hiroyuki
2007-11-27 3:00 ` [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [3/10] per-zone active inactive counter KAMEZAWA Hiroyuki
2007-11-28 21:19 ` Lee Schermerhorn
2007-11-29 1:37 ` KAMEZAWA Hiroyuki
2007-11-29 2:24 ` KAMEZAWA Hiroyuki
2007-11-29 3:18 ` KAMEZAWA Hiroyuki
2007-11-29 3:26 ` Christoph Lameter
2007-11-29 3:19 ` YAMAMOTO Takashi [this message]
2007-11-29 3:25 ` KAMEZAWA Hiroyuki
2007-11-29 3:33 ` YAMAMOTO Takashi
2007-11-29 3:42 ` KAMEZAWA Hiroyuki
2007-11-27 3:01 ` [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [4/10] calculate mapper_ratio per cgroup KAMEZAWA Hiroyuki
2007-11-27 3:03 ` [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [5/10] calculate active/inactive imbalance " KAMEZAWA Hiroyuki
2007-11-27 3:04 ` [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [6/10] remember reclaim priority in memory cgroup KAMEZAWA Hiroyuki
2007-11-27 3:06 ` [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [7/10] calculate the number of pages to be scanned per cgroup KAMEZAWA Hiroyuki
2007-11-27 3:08 ` [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [8/10] modifies vmscan.c for isolate globa/cgroup lru activity KAMEZAWA Hiroyuki
2007-11-27 3:10 ` [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [9/10] per zone lru for cgroup KAMEZAWA Hiroyuki
2007-11-27 3:11 ` [PATCH][for -mm] per-zone and reclaim enhancements for memory controller take 3 [10/10] per-zone-lock " KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071129031937.3C86F1CFE80@siro.lan \
--to=yamamoto@valinux.co.jp \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.osdl.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox