Re: [PATCH] mem notifications v2

[kosaki <kosaki.motohiro@jp.fujitsu.com>]

Hi, Marcelo

> > Why you use total_swap_pages?
> > Are your intent watching swapon/spwapoff syscall? 
> > 
> > or, s/total_swapcache_pages/nr_swap_pages/ ?
> 
> Oops.
> 
> total_anon_pages() is supposed to return the total number of anonymous pages
> (including swapped out ones), so that should be: 
> 
> #define total_anon_pages() (global_page_state(NR_ANON_PAGES) + \
>                            (total_swap_pages-nr_swap_pages)  - \
>                             total_swapcache_pages

Thank you for your kindness explain.
I understand it.


result of re-reviewed, I have 2 comment. 

1. mem_notify_status turn off in poll is a bit wrong.
   beacause "/dev/mem_notify" watched by multi process is common situation.
2. If it is possible, We may add read method.
   because script language kind to read rather than poll.

especially, I want hear your opinion by comment 2.
I have no confident.


BTW, Do I have any other contribution things for you?


----
kosaki


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>