From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [RFC][ for -mm] memory controller enhancements for NUMA [1/10] record nid/zid on page_cgroup In-Reply-To: Your message of "Wed, 14 Nov 2007 17:41:31 +0900" <20071114174131.cf7c4aa6.kamezawa.hiroyu@jp.fujitsu.com> References: <20071114174131.cf7c4aa6.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Message-Id: <20071114092243.9331F1CD66B@siro.lan> Date: Wed, 14 Nov 2007 18:22:43 +0900 (JST) From: yamamoto@valinux.co.jp (YAMAMOTO Takashi) Sender: owner-linux-mm@kvack.org Return-Path: To: kamezawa.hiroyu@jp.fujitsu.com Cc: linux-mm@kvack.org, containers@lists.osdl.org, balbir@linux.vnet.ibm.com, hugh@veritas.com List-ID: > This patch adds nid/zoneid value to page cgroup. > This helps per-zone accounting for memory cgroup and reclaim routine. > > Signed-off-by: KAMEZAWA Hiroyuki > > mm/memcontrol.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > Index: linux-2.6.24-rc2-mm1/mm/memcontrol.c > =================================================================== > --- linux-2.6.24-rc2-mm1.orig/mm/memcontrol.c > +++ linux-2.6.24-rc2-mm1/mm/memcontrol.c > @@ -131,6 +131,8 @@ struct page_cgroup { > atomic_t ref_cnt; /* Helpful when pages move b/w */ > /* mapped and cached states */ > int flags; > + short nid; > + short zid; > }; > #define PAGE_CGROUP_FLAG_CACHE (0x1) /* charged as cache */ > #define PAGE_CGROUP_FLAG_ACTIVE (0x2) /* page is active in this cgroup */ > @@ -216,6 +218,10 @@ void page_assign_page_cgroup(struct page > VM_BUG_ON(!page_cgroup_locked(page)); > locked = (page->page_cgroup & PAGE_CGROUP_LOCK); > page->page_cgroup = ((unsigned long)pc | locked); > + if (pc) { > + pc->nid = page_to_nid(page); > + pc->zid = page_zonenum(page); > + } > } > > struct page_cgroup *page_get_page_cgroup(struct page *page) are they worth to be cached? can't you use page_zonenum(pc->page)? YAMAMOTO Takashi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org