From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [RFC][ for -mm] memory controller enhancements for NUMA [10/10] per-zone-lru In-Reply-To: Your message of "Wed, 14 Nov 2007 17:57:37 +0900" <20071114175737.d5066644.kamezawa.hiroyu@jp.fujitsu.com> References: <20071114175737.d5066644.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Message-Id: <20071114091138.30BA11CD65F@siro.lan> Date: Wed, 14 Nov 2007 18:11:37 +0900 (JST) From: yamamoto@valinux.co.jp (YAMAMOTO Takashi) Sender: owner-linux-mm@kvack.org Return-Path: To: kamezawa.hiroyu@jp.fujitsu.com Cc: containers@lists.osdl.org, linux-mm@kvack.org, hugh@veritas.com, balbir@linux.vnet.ibm.com List-ID: > +struct mc_lru_head { > + struct list_head active_list[MAX_NR_ZONES]; > + struct list_head inactive_list[MAX_NR_ZONES]; > +}; > + i guess struct foo { struct list_head active_list; struct list_head inactive_list; } lists[MAX_NR_ZONES]; is better. > @@ -139,8 +144,20 @@ struct mem_cgroup { > * Per zone statistics (used for memory reclaim) > */ > struct mem_cgroup_zonestat zstat; > +#ifndef CONFIG_NUMA > + struct lru_head local_head; > +#endif struct mc_lru_head local_lru; > +static int mem_cgroup_init_lru(struct mem_cgroup *mem) > +{ > + int zone; > + mem->lrus[0] = &mem->local_lru; 'zone' seems unused. YAMAMOTO Takashi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org