From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andy Whitcroft <apw@shadowen.org>, linux-mm@kvack.org
Subject: Re: Sparsemem: Do not reserve section flags if VMEMMAP is in use
Date: Tue, 13 Nov 2007 13:46:03 +0900 [thread overview]
Message-ID: <20071113134603.5b4b0f24.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0711121944400.30269@schroedinger.engr.sgi.com>
On Mon, 12 Nov 2007 19:47:06 -0800 (PST)
Christoph Lameter <clameter@sgi.com> wrote:
> Index: linux-2.6/include/linux/mm.h
> ===================================================================
> --- linux-2.6.orig/include/linux/mm.h 2007-11-12 19:36:39.472347109 -0800
> +++ linux-2.6/include/linux/mm.h 2007-11-12 19:37:05.197064250 -0800
> @@ -378,7 +378,7 @@ static inline void set_compound_order(st
> * with space for node: | SECTION | NODE | ZONE | ... | FLAGS |
> * no space for node: | SECTION | ZONE | ... | FLAGS |
> */
> -#ifdef CONFIG_SPARSEMEM
> +#if defined(CONFIG_SPARSEMEM) && !defined(CONFIG_SPARSEMEM_VMEMMAP)
> #define SECTIONS_WIDTH SECTIONS_SHIFT
> #else
> #define SECTIONS_WIDTH 0
>
I like this. but it may safe to add this definition to do this..
==
#if SECTIONS_WIDTH > 0
static inline page_to_section(struct page *page)
{
return pfn_to_section(page_to_pfn(page));
}
else
....
#endif
==
page_to_section is used in page_to_nid() if NODE_NOT_IN_PAGE_FLAGS=y.
(I'm not sure exact config dependency.)
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-11-13 4:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 3:47 Christoph Lameter
2007-11-13 4:46 ` KAMEZAWA Hiroyuki [this message]
2007-11-13 21:38 ` Christoph Lameter
2007-11-14 0:19 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071113134603.5b4b0f24.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=apw@shadowen.org \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox