From: "Jörn Engel" <joern@logfs.org>
To: Andreas Schwab <schwab@suse.de>
Cc: "Jörn Engel" <joern@logfs.org>,
"Christoph Lameter" <clameter@sgi.com>,
akpm@linux-foundatin.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, "Mel Gorman" <mel@skynet.ie>
Subject: Re: [patch 14/23] inodes: Support generic defragmentation
Date: Wed, 7 Nov 2007 11:35:55 +0100 [thread overview]
Message-ID: <20071107103554.GF7374@lazybastard.org> (raw)
In-Reply-To: <je8x5aibry.fsf@sykes.suse.de>
On Wed, 7 November 2007 11:35:13 +0100, Andreas Schwab wrote:
> >
> > The fact that all pointers get changed makes me a bit uneasy:
> > struct foo_inode v[20];
> > ...
> > fs_get_inodes(..., v, ...);
> > ...
> > v[0].foo_field = bar;
> >
> > No warning, but spectacular fireworks.
>
> You'l get a warning that struct foo_inode * is incompatible with void **.
- struct foo_inode v[20];
+ struct foo_inode *v[20];
Looks like my example needs a patch as well. Anyway, the function is
used in a way that makes this a non-issue.
JA?rn
--
You cannot suppose that Moliere ever troubled himself to be original in the
matter of ideas. You cannot suppose that the stories he tells in his plays
have never been told before. They were culled, as you very well know.
-- Andre-Louis Moreau in Scarabouche
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-11-07 10:35 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 1:11 [patch 00/23] Slab defragmentation V6 Christoph Lameter
2007-11-07 1:11 ` [patch 01/23] SLUB: Move count_partial() Christoph Lameter
2007-11-07 1:11 ` [patch 02/23] SLUB: Rename NUMA defrag_ratio to remote_node_defrag_ratio Christoph Lameter
2007-11-08 14:50 ` Mel Gorman
2007-11-08 17:25 ` Matt Mackall
2007-11-08 19:16 ` Christoph Lameter
2007-11-08 19:47 ` Matt Mackall
2007-11-08 20:01 ` Christoph Lameter
2007-11-08 21:03 ` Matt Mackall
2007-11-08 21:28 ` Christoph Lameter
2007-11-08 23:08 ` Matt Mackall
2007-11-08 18:56 ` Christoph Lameter
2007-11-08 20:10 ` Mel Gorman
2007-11-07 1:11 ` [patch 03/23] bufferhead: Revert constructor removal Christoph Lameter
2007-11-07 1:11 ` [patch 04/23] dentries: Extract common code to remove dentry from lru Christoph Lameter
2007-11-07 8:50 ` Johannes Weiner
2007-11-07 9:43 ` Jörn Engel
2007-11-07 18:55 ` Christoph Lameter
2007-11-07 18:54 ` Jörn Engel
2007-11-07 19:00 ` Christoph Lameter
2007-11-07 18:28 ` Christoph Lameter
2007-11-07 1:11 ` [patch 05/23] VM: Allow get_page_unless_zero on compound pages Christoph Lameter
2007-11-07 1:11 ` [patch 06/23] SLUB: Extend slabinfo to support -D and -C options Christoph Lameter
2007-11-08 15:00 ` Mel Gorman
2007-11-07 1:11 ` [patch 07/23] SLUB: Add defrag_ratio field and sysfs support Christoph Lameter
2007-11-07 8:55 ` Johannes Weiner
2007-11-07 18:30 ` Christoph Lameter
2007-11-08 15:07 ` Mel Gorman
2007-11-08 18:59 ` Christoph Lameter
2007-11-07 1:11 ` [patch 08/23] SLUB: Replace ctor field with ops field in /sys/slab/:0000008 /sys/slab/:0000016 /sys/slab/:0000024 /sys/slab/:0000032 /sys/slab/:0000040 /sys/slab/:0000048 /sys/slab/:0000056 /sys/slab/:0000064 /sys/slab/:0000072 /sys/slab/:0000080 /sys/slab/:0000088 /sys/slab/:0000096 /sys/slab/:0000104 /sys/slab/:0000128 /sys/slab/:0000144 /sys/slab/:0000184 /sys/slab/:0000192 /sys/slab/:0000216 /sys/slab/:0000256 /sys/slab/:0000344 /sys/slab/:0000384 /sys/slab/:0000448 /sys/slab/:0000512 /sys/slab/:0000768 /sys/slab/:0000968 /sys/slab/:0001024 /sys/slab/:0001152 /sys/slab/:0001312 /sys/slab/:0001536 /sys/slab/:0002048 /sys/slab/:0003072 /sys/slab/:0004096 /sys/slab/:a-0000016 /sys/slab/:a-0000024 /sys/slab/:a-0000056 /sys/slab/:a-0000080 /sys/slab/:a-0000128 /sys/slab/Acpi-Namesp ace /sys/slab/Acpi-Operand /sys/slab/Acpi-Parse /sys/slab/Acpi-ParseExt /sys/slab/Acpi-State /sys/ Christoph Lameter
2007-11-07 1:11 ` [patch 09/23] SLUB: Add get() and kick() methods Christoph Lameter
2007-11-07 2:37 ` Adrian Bunk
2007-11-07 3:07 ` Christoph Lameter
2007-11-07 3:26 ` Adrian Bunk
2007-11-07 1:11 ` [patch 10/23] SLUB: Sort slab cache list and establish maximum objects for defrag slabs Christoph Lameter
2007-11-07 1:11 ` [patch 11/23] SLUB: Slab defrag core Christoph Lameter
2007-11-07 22:13 ` Christoph Lameter
2007-11-07 1:11 ` [patch 12/23] SLUB: Trigger defragmentation from memory reclaim Christoph Lameter
2007-11-07 9:28 ` Johannes Weiner
2007-11-07 18:34 ` Christoph Lameter
2007-11-08 15:12 ` Mel Gorman
2007-11-08 19:00 ` Christoph Lameter
2007-11-07 1:11 ` [patch 13/23] Buffer heads: Support slab defrag Christoph Lameter
2007-11-07 1:11 ` [patch 14/23] inodes: Support generic defragmentation Christoph Lameter
2007-11-07 10:17 ` Jörn Engel
2007-11-07 10:31 ` Jörn Engel
2007-11-07 10:35 ` Andreas Schwab
2007-11-07 10:35 ` Jörn Engel [this message]
2007-11-07 18:40 ` Christoph Lameter
2007-11-07 18:51 ` Jörn Engel
2007-11-07 19:00 ` Christoph Lameter
2007-11-07 1:11 ` [patch 15/23] FS: ExtX filesystem defrag Christoph Lameter
2007-11-07 1:11 ` [patch 16/23] FS: XFS slab defragmentation Christoph Lameter
2007-11-07 1:11 ` [patch 17/23] FS: Proc filesystem support for slab defrag Christoph Lameter
2007-11-07 1:11 ` [patch 18/23] FS: Slab defrag: Reiserfs support Christoph Lameter
2007-11-07 1:11 ` [patch 19/23] FS: Socket inode defragmentation Christoph Lameter
2007-11-07 1:11 ` [patch 20/23] dentries: Add constructor Christoph Lameter
2007-11-08 15:23 ` Mel Gorman
2007-11-08 19:03 ` Christoph Lameter
2007-11-07 1:11 ` [patch 21/23] dentries: dentry defragmentation Christoph Lameter
2007-11-07 1:11 ` [patch 22/23] SLUB: Slab reclaim through Lumpy reclaim Christoph Lameter
2007-11-07 1:11 ` [patch 23/23] SLUB: Add SlabReclaimable() to avoid repeated reclaim attempts Christoph Lameter
2007-11-08 15:26 ` [patch 00/23] Slab defragmentation V6 Mel Gorman
2007-11-08 16:01 ` Plans for Onezonelist patch series ??? Lee Schermerhorn
2007-11-08 18:34 ` Christoph Lameter
2007-11-08 18:40 ` Mel Gorman
2007-11-08 18:43 ` Christoph Lameter
2007-11-08 20:06 ` Mel Gorman
2007-11-08 20:20 ` Christoph Lameter
2007-11-08 20:29 ` Mel Gorman
2007-11-08 18:39 ` Mel Gorman
2007-11-08 19:39 ` Christoph Lameter
2007-11-08 19:12 ` [patch 00/23] Slab defragmentation V6 Christoph Lameter
2007-11-08 20:24 ` Mel Gorman
2007-11-08 20:28 ` Christoph Lameter
2007-11-08 20:58 ` Lee Schermerhorn
2007-11-08 21:27 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071107103554.GF7374@lazybastard.org \
--to=joern@logfs.org \
--cc=akpm@linux-foundatin.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@skynet.ie \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox