From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 7 Nov 2007 04:26:22 +0100 From: Adrian Bunk Subject: Re: [patch 09/23] SLUB: Add get() and kick() methods Message-ID: <20071107032622.GV26163@stusta.de> References: <20071107011130.382244340@sgi.com> <20071107011228.605750914@sgi.com> <20071107023709.GU26163@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mel Gorman , Rik van Riel List-ID: On Tue, Nov 06, 2007 at 07:07:15PM -0800, Christoph Lameter wrote: > On Wed, 7 Nov 2007, Adrian Bunk wrote: > > > A static inline dummy function for CONFIG_SLUB=n seems to be missing? > > Correct. This patch is needed so that building with SLAB will work. > > Slab defrag: Provide empty kmem_cache_setup_defrag function for SLAB. > > Provide an empty function to satisfy dependencies for Slab defrag. > > Signed-off-by: Christoph Lameter ? > > --- > mm/slab.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > Index: linux-2.6/mm/slab.c > =================================================================== > --- linux-2.6.orig/mm/slab.c 2007-11-06 18:57:22.000000000 -0800 > +++ linux-2.6/mm/slab.c 2007-11-06 18:58:40.000000000 -0800 > @@ -2535,6 +2535,13 @@ static int __cache_shrink(struct kmem_ca > return (ret ? 1 : 0); > } > > +void kmem_cache_setup_defrag(struct kmem_cache *s, > + void *(*get)(struct kmem_cache *, int nr, void **), > + void (*kick)(struct kmem_cache *, int nr, void **, void *private)) > +{ > +} > +EXPORT_SYMBOL(kmem_cache_setup_defrag); > + - this misses slob - this wastes memory An empty static inline function in slab.h would be better. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org