From: Matt Mackall <mpm@selenic.com>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: linux-mm <linux-mm@kvack.org>, Adrian Bunk <bunk@stusta.de>,
Hugh@waste.org
Date: Fri, 2 Nov 2007 13:28:46 -0500 [thread overview]
Message-ID: <20071102182846.GO19691@waste.org> (raw)
Dickins <hugh@veritas.com>
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Bcc:
Subject: Re: [PATCH] Remove unused code from mm/tiny-shmem.c
Reply-To:
In-Reply-To: <20071102172056.14261.39829.sendpatchset@balbir-laptop>
On Fri, Nov 02, 2007 at 10:50:56PM +0530, Balbir Singh wrote:
> This code in mm/tiny-shmem.c is under #if 0, do we really need it? This
> patch removes it.
>
> Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
Adrian added the #ifdefs in March, not sure why he didn't kill it outright.
Acked-by: Matt Mackall <mpm@selenic.com>
> mm/tiny-shmem.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff -puN mm/tiny-shmem.c~remove-unused-code mm/tiny-shmem.c
> --- linux-2.6-latest/mm/tiny-shmem.c~remove-unused-code 2007-11-02 22:43:12.000000000 +0530
> +++ linux-2.6-latest-balbir/mm/tiny-shmem.c 2007-11-02 22:43:30.000000000 +0530
> @@ -121,18 +121,6 @@ int shmem_unuse(swp_entry_t entry, struc
> return 0;
> }
>
> -#if 0
> -int shmem_mmap(struct file *file, struct vm_area_struct *vma)
> -{
> - file_accessed(file);
> -#ifndef CONFIG_MMU
> - return ramfs_nommu_mmap(file, vma);
> -#else
> - return 0;
> -#endif
> -}
> -#endif /* 0 */
> -
> #ifndef CONFIG_MMU
> unsigned long shmem_get_unmapped_area(struct file *file,
> unsigned long addr,
--
Mathematics is the supreme nostalgia of our time.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
reply other threads:[~2007-11-02 18:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071102182846.GO19691@waste.org \
--to=mpm@selenic.com \
--cc=Hugh@waste.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=bunk@stusta.de \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox