linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Remove unused code from mm/tiny-shmem.c
@ 2007-11-02 17:20 Balbir Singh
  2007-11-02 19:48 ` Matt Mackall
  0 siblings, 1 reply; 2+ messages in thread
From: Balbir Singh @ 2007-11-02 17:20 UTC (permalink / raw)
  To: Matt Mackall
  Cc: Balbir Singh, linux-mm, Andrew Morton, Linux Kernel Mailing List


This code in mm/tiny-shmem.c is under #if 0, do we really need it? This
patch removes it.

Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
---

 mm/tiny-shmem.c |   12 ------------
 1 file changed, 12 deletions(-)

diff -puN mm/tiny-shmem.c~remove-unused-code mm/tiny-shmem.c
--- linux-2.6-latest/mm/tiny-shmem.c~remove-unused-code	2007-11-02 22:43:12.000000000 +0530
+++ linux-2.6-latest-balbir/mm/tiny-shmem.c	2007-11-02 22:43:30.000000000 +0530
@@ -121,18 +121,6 @@ int shmem_unuse(swp_entry_t entry, struc
 	return 0;
 }
 
-#if 0
-int shmem_mmap(struct file *file, struct vm_area_struct *vma)
-{
-	file_accessed(file);
-#ifndef CONFIG_MMU
-	return ramfs_nommu_mmap(file, vma);
-#else
-	return 0;
-#endif
-}
-#endif  /*  0  */
-
 #ifndef CONFIG_MMU
 unsigned long shmem_get_unmapped_area(struct file *file,
 				      unsigned long addr,
_

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Remove unused code from mm/tiny-shmem.c
  2007-11-02 17:20 [PATCH] Remove unused code from mm/tiny-shmem.c Balbir Singh
@ 2007-11-02 19:48 ` Matt Mackall
  0 siblings, 0 replies; 2+ messages in thread
From: Matt Mackall @ 2007-11-02 19:48 UTC (permalink / raw)
  To: Balbir Singh
  Cc: linux-mm, Adrian Bunk, Hugh Dickins, Andrew Morton,
	Linux Kernel Mailing List

[resent due to damaged header]

On Fri, Nov 02, 2007 at 10:50:56PM +0530, Balbir Singh wrote:
> This code in mm/tiny-shmem.c is under #if 0, do we really need it? This
> patch removes it.
> 
> Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>

Adrian added the #ifdefs in March, not sure why he didn't kill it outright.

Acked-by: Matt Mackall <mpm@selenic.com>

>  mm/tiny-shmem.c |   12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff -puN mm/tiny-shmem.c~remove-unused-code mm/tiny-shmem.c
> --- linux-2.6-latest/mm/tiny-shmem.c~remove-unused-code	2007-11-02 22:43:12.000000000 +0530
> +++ linux-2.6-latest-balbir/mm/tiny-shmem.c	2007-11-02 22:43:30.000000000 +0530
> @@ -121,18 +121,6 @@ int shmem_unuse(swp_entry_t entry, struc
>  	return 0;
>  }
>  
> -#if 0
> -int shmem_mmap(struct file *file, struct vm_area_struct *vma)
> -{
> -	file_accessed(file);
> -#ifndef CONFIG_MMU
> -	return ramfs_nommu_mmap(file, vma);
> -#else
> -	return 0;
> -#endif
> -}
> -#endif  /*  0  */
> -
>  #ifndef CONFIG_MMU
>  unsigned long shmem_get_unmapped_area(struct file *file,
>  				      unsigned long addr,

-- 
Mathematics is the supreme nostalgia of our time.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-11-02 19:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-02 17:20 [PATCH] Remove unused code from mm/tiny-shmem.c Balbir Singh
2007-11-02 19:48 ` Matt Mackall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox