From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 30 Oct 2007 14:47:45 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH][BUGFIX][for -mm] Misc fix for memory cgroup [4/5] skip !PageLRU page in mem_cgroup_isolate_pages Message-Id: <20071030144745.1af1cbde.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20071011140115.173d1a9d.kamezawa.hiroyu@jp.fujitsu.com> References: <20071011135345.5d9a4c06.kamezawa.hiroyu@jp.fujitsu.com> <20071011140115.173d1a9d.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: Andrew Morton , "balbir@linux.vnet.ibm.com" , "linux-mm@kvack.org" , "containers@lists.osdl.org" List-ID: I'm sorry that this patch needs following fix.. Andrew, could you apply this ? (All version I sent has this bug....Sigh) Thanks, -Kame == Bugfix for memory cgroup skip !PageLRU page in mem_cgroup_isolate_pages Signed-off-by: KAMEZAWA Hiroyuki Index: devel-2.6.23-mm1/mm/memcontrol.c =================================================================== --- devel-2.6.23-mm1.orig/mm/memcontrol.c +++ devel-2.6.23-mm1/mm/memcontrol.c @@ -260,7 +260,7 @@ unsigned long mem_cgroup_isolate_pages(u spin_lock(&mem_cont->lru_lock); scan = 0; list_for_each_entry_safe_reverse(pc, tmp, src, lru) { - if (scan++ > nr_taken) + if (scan++ > nr_to_scan) break; page = pc->page; VM_BUG_ON(!pc); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org