From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 23 Oct 2007 14:35:01 +0900 From: Yasunori Goto Subject: Re: [PATCH] Fix warning in mm/slub.c In-Reply-To: <20071023042153.GA20693@lixom.net> References: <20071018122345.514F.Y-GOTO@jp.fujitsu.com> <20071023042153.GA20693@lixom.net> Message-Id: <20071023143212.8D2E.Y-GOTO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Olof Johansson Cc: Andrew Morton , Christoph Lameter , Linux Kernel ML , linux-mm List-ID: > "Make kmem_cache_node for SLUB on memory online to avoid panic" introduced > the following: > > mm/slub.c:2737: warning: passing argument 1 of 'atomic_read' from > incompatible pointer type > > > Signed-off-by: Olof Johansson > > > diff --git a/mm/slub.c b/mm/slub.c > index aac1dd3..bcdb2c8 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2734,7 +2734,7 @@ static void slab_mem_offline_callback(void *arg) > * and offline_pages() function shoudn't call this > * callback. So, we must fail. > */ > - BUG_ON(atomic_read(&n->nr_slabs)); > + BUG_ON(atomic_long_read(&n->nr_slabs)); > > s->node[offline_node] = NULL; > kmem_cache_free(kmalloc_caches, n); Oops, yes. Thanks. Acked-by: Yasunori Goto -- Yasunori Goto -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org