From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e5.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id l9AG5V1J020120 for ; Wed, 10 Oct 2007 12:05:31 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l9AG5Vo8490994 for ; Wed, 10 Oct 2007 12:05:31 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l9AG5KqH015684 for ; Wed, 10 Oct 2007 12:05:20 -0400 Date: Wed, 10 Oct 2007 09:05:08 -0700 From: Nishanth Aravamudan Subject: Re: [PATCH 6/6] Use one zonelist that is filtered by nodemask Message-ID: <20071010160508.GE26472@us.ibm.com> References: <20070928142326.16783.98817.sendpatchset@skynet.skynet.ie> <20070928142526.16783.97067.sendpatchset@skynet.skynet.ie> <20071009011143.GC14670@us.ibm.com> <20071009154052.GC12632@skynet.ie> <1192031620.5617.39.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1192031620.5617.39.camel@localhost> Sender: owner-linux-mm@kvack.org Return-Path: To: Lee Schermerhorn Cc: Mel Gorman , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rientjes@google.com, kamezawa.hiroyu@jp.fujitsu.com, clameter@sgi.com List-ID: On 10.10.2007 [11:53:40 -0400], Lee Schermerhorn wrote: > On Tue, 2007-10-09 at 16:40 +0100, Mel Gorman wrote: > > > ==== > > Subject: Use specified node ID with GFP_THISNODE if available > > > > It had been assumed that __GFP_THISNODE meant allocating from the local > > node and only the local node. However, users of alloc_pages_node() may also > > specify GFP_THISNODE. In this case, only the specified node should be used. > > This patch will allocate pages only from the requested node when GFP_THISNODE > > is used with alloc_pages_node(). > > > > [nacc@us.ibm.com: Detailed analysis of problem] > > Found-by: Lee Schermerhorn > > Signed-off-by: Mel Gorman > > > > > Mel: I applied this patch [to your v8 series--the most recent, I > think?] and it does fix the problem. However, now I'm tripping over > this warning in __alloc_pages_nodemask: > > /* Specifying both __GFP_THISNODE and nodemask is stupid. Warn user */ > WARN_ON(gfp_mask & __GFP_THISNODE); > > for each huge page allocated. Rather slow as my console is a virtual > serial line and the warning includes the stack traceback. > > I think we want to just drop this warning, but maybe you have a tighter > condition that you want to warn about? Sigh, sorry Mel. I see this too on my box. I purely checked the functionality and didn't think to check the logs, as the tests worked :/ I think it's quite clear that the WARN_ON() makes no sense now, since alloc_pages_node() now calls __alloc_pages_nodemask(). -Nish -- Nishanth Aravamudan IBM Linux Technology Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org