From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
Cc: containers@lists.osdl.org, linux-mm@kvack.org,
akpm@linux-foundation.org, balbir@linux.vnet.ibm.com
Subject: Re: [PATCH][for -mm] Fix and Enhancements for memory cgroup [1/6] fix refcnt race in charge/uncharge
Date: Wed, 10 Oct 2007 09:34:42 +0900 [thread overview]
Message-ID: <20071010093442.7ade1b8d.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20071009223139.061C21BF47A@siro.lan>
On Wed, 10 Oct 2007 07:31:38 +0900 (JST)
yamamoto@valinux.co.jp (YAMAMOTO Takashi) wrote:
> > - atomic_inc(&pc->ref_cnt);
> > - goto done;
> > + if (unlikely(!atomic_inc_not_zero(&pc->ref_cnt))) {
> > + /* this page is under being uncharge ? */
> > + unlock_page_cgroup(page);
>
> cpu_relax() here?
>
Ah, yes. there should be. I'll add.
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-10-10 0:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 9:46 [PATCH][for -mm] Fix and Enhancements for memory cgroup [0/6] intro KAMEZAWA Hiroyuki
2007-10-09 9:49 ` [PATCH][for -mm] Fix and Enhancements for memory cgroup [1/6] fix refcnt race in charge/uncharge KAMEZAWA Hiroyuki
2007-10-09 10:38 ` Balbir Singh
2007-10-09 22:31 ` YAMAMOTO Takashi
2007-10-10 0:34 ` KAMEZAWA Hiroyuki [this message]
2007-10-09 9:50 ` [PATCH][for -mm] Fix and Enhancements for memory cgroup [2/6] fix err handling in charging KAMEZAWA Hiroyuki
2007-10-09 10:48 ` Balbir Singh
2007-10-09 9:51 ` [PATCH][for -mm] Fix and Enhancements for memory cgroup [3/6] add helper function for page_cgroup KAMEZAWA Hiroyuki
2007-10-09 11:09 ` Balbir Singh
2007-10-09 11:26 ` KAMEZAWA Hiroyuki
2007-10-10 0:38 ` KAMEZAWA Hiroyuki
2007-10-09 9:53 ` [PATCH][for -mm] Fix and Enhancements for memory cgroup [4/6] avoid handling !LRU page in mem_cgroup_isolate_pages KAMEZAWA Hiroyuki
2007-10-09 15:35 ` Balbir Singh
2007-10-09 9:54 ` [PATCH][for -mm] Fix and Enhancements for memory cgroup [5/6] memory cgroup and migration fix KAMEZAWA Hiroyuki
2007-10-09 16:26 ` Balbir Singh
2007-10-09 9:55 ` [PATCH][for -mm] Fix and Enhancements for memory cgroup [6/6] add force reclaim interface KAMEZAWA Hiroyuki
2007-10-09 18:44 ` Balbir Singh
2007-10-10 0:41 ` KAMEZAWA Hiroyuki
2007-10-09 10:30 ` [PATCH][for -mm] Fix and Enhancements for memory cgroup [0/6] intro Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071010093442.7ade1b8d.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.osdl.org \
--cc=linux-mm@kvack.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox