From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 8 Oct 2007 13:23:04 -0400 From: Rik van Riel Subject: Re: [PATCH]fix page release issue in filemap_fault Message-ID: <20071008132304.7382961d@bree.surriel.com> In-Reply-To: <1191863723.20745.26.camel@twins> References: <3d0408630710080828h7ad160dbxf6cbd8513c1ad3e8@mail.gmail.com> <1191863723.20745.26.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Peter Zijlstra Cc: Yan Zheng , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org List-ID: On Mon, 08 Oct 2007 19:15:23 +0200 Peter Zijlstra wrote: > On Mon, 2007-10-08 at 23:28 +0800, Yan Zheng wrote: > > Hi all > > > > find_lock_page increases page's usage count, we should decrease it > > before return VM_FAULT_SIGBUS > > > > Signed-off-by: Yan Zheng > > Nice catch, .23 material? An obvious fix for a memory leak. I think it should go in. > Acked-by: Peter Zijlstra Acked-by: Rik van Riel -- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." - Brian W. Kernighan -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org