Re: [patch -mm 7/5] oom: filter tasklist dump by mem_cgroup

[Paul Jackson <pj@sgi.com>]

pj wrote:
> current task.  But what about configurations using overlapping cpusets
> but not CONSTRAINT_CPUSET?

David replied:
> CONSTRAINT_CPUSET isn't as simple as just killing current anymore in -mm.  
> For that behavior, you need
> 
> 	echo 1 > /proc/sys/vm/oom_kill_allocating_task

True.

... but what about configs with overlappnig cpusets that don't set
oom_kill_allocating_tasks ?

To connect back this back to the original point:

On 9/25/07, David Rientjes <rientjes@google.com> wrote:
> If an OOM was triggered as a result a cgroup's memory controller, the
> tasklist shall be filtered to exclude tasks that are not a member of the
> same group.

I would think that excluding tasks not in the same cpuset (if that's what
"not a member of the same group" would mean here) wouldn't be the right
thing to do, if the cpusets had overlapping mems_allowed and if we had
not set oom_kill_allocating_task.

... or am I still exposing my ignorance ??

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>