Re: [PATCH 3/4] hugetlb: interleave dequeueing of huge pages

[Nishanth Aravamudan <nacc@us.ibm.com>]

On 14.09.2007 [16:33:00 -0400], Lee Schermerhorn wrote:
> On Fri, 2007-09-14 at 13:16 -0700, Christoph Lameter wrote:
> > On Fri, 14 Sep 2007, Lee Schermerhorn wrote:
> > 
> > > Yeah, I mistyped...  But, nid IS private to that function.  This is a
> > > valid use of static.  But, perhaps it could use a comment to call
> > > attention to it.
> > 
> > I think its best to move nis outside of the function and give it a longer 
> > name that is distinctive from names we use for local variables. F.e.
> > 
> > last_allocated_node
> > 
> > ?
> 
> I do like to see variables' [and functions'] visibility kept within
> the minimum necessary scope, and moving it outside of the function
> violates this.  Nothing else in the source file needs it.  But, If
> Nish agrees, I guess I don't feel that strongly about it.  I like the
> suggested name, tho'

I've changed the name, but I don't see how moving the scope helps. I
guess I could it make it globally static -- as opposed to local to the
function -- and then it would be easier to dequeue based upon the
global's value (something Lee asked for earlier). However, that would
require locking to avoid races between two processes both echo'ing
values into the sysctl? I guess it's not a serious race with the sanity
check that Andrew has in there, it just means sometimes a node might get
skipped in the interleaving...

Thanks,
Nish

-- 
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>