From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 19 Sep 2007 15:45:42 -0700 From: Andrew Morton Subject: Re: VM/VFS bug with large amount of memory and file systems? Message-Id: <20070919154542.4ed8ea1e.akpm@linux-foundation.org> In-Reply-To: <46F19ED6.20501@redhat.com> References: <1189850897.21778.301.camel@twins> <20070915035228.8b8a7d6d.akpm@linux-foundation.org> <13126578-A4F8-43EA-9B0D-A3BCBFB41FEC@cam.ac.uk> <20070917163257.331c7605@twins> <46EEB532.3060804@redhat.com> <20070917131526.e8db80fe.akpm@linux-foundation.org> <46EEE7B7.1070206@redhat.com> <20070917141127.ab2ae148.akpm@linux-foundation.org> <46F19ED6.20501@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Rik van Riel Cc: Peter Zijlstra , Anton Altaparmakov , Linux Kernel Mailing List , Linux Memory Management List , marc.smith@esmail.mcc.edu, Christoph Lameter List-ID: On Wed, 19 Sep 2007 18:12:38 -0400 Rik van Riel wrote: > Andrew Morton wrote: > > On Mon, 17 Sep 2007 16:46:47 -0400 > > Rik van Riel wrote: > > >> Is the slab defragmentation code in -mm or upstream already > >> or can I find it on the mailing list? > > > > Is on lkml and linux-mm: http://lkml.org/lkml/2007/8/31/329 > > > I think the whole approach is reasonable. It's mainly a matter of going > > through it all with a toothcomb > > I've spent the last two days combing through the patches. Thanks. So would it be appropriate for Christoph to add the thus-far-undefined reviewed-by tag to the next version? > Except for the one doubt I had (resolved in email), and > one function name comment (on patch 18/26) yeah. Basic rule: if the reviewer had to ask a question then others will later ask themselves the same question when reading the code. So this is a very good indicator that there is a missing code comment. > the code looks > good to me. Cool. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org