linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Adam Litke <agl@us.ibm.com>
To: linux-mm@kvack.org
Cc: libhugetlbfs-devel@lists.sourceforge.net,
	Adam Litke <agl@us.ibm.com>, Andy Whitcroft <apw@shadowen.org>,
	Mel Gorman <mel@skynet.ie>, Bill Irwin <bill.irwin@oracle.com>,
	Ken Chen <kenchen@google.com>,
	Dave McCracken <dave.mccracken@oracle.com>
Subject: [PATCH 1/5] hugetlb: Account for hugepages as locked_vm
Date: Thu, 13 Sep 2007 10:59:05 -0700	[thread overview]
Message-ID: <20070913175905.27074.92434.stgit@kernel> (raw)
In-Reply-To: <20070913175855.27074.27030.stgit@kernel>

Hugepages allocated to a process are pinned into memory and are not
reclaimable.  Currently they do not contribute towards the process' locked
memory.  This patch includes those pages in the process' 'locked_vm' pages.

NOTE: The locked_vm counter is only updated at fault and unmap time.  Huge
pages are different from regular mlocked memory which is faulted in all at
once.  Therefore, it does not make sense to charge at mmap time for huge
page mappings.  This difference results in a deviation from normal mlock
accounting which cannot be trivially reconciled given the inherent
differences with huge pages.

Signed-off-by: Adam Litke <agl@us.ibm.com>
Signed-off-by: Mel Gorman <mel@csn.ul.ie>
Acked-by: Andy Whitcroft <apw@shadowen.org>
---

 mm/hugetlb.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index de4cf45..1dfeafa 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -428,6 +428,7 @@ void __unmap_hugepage_range(struct vm_area_struct *vma, unsigned long start,
 			continue;
 
 		page = pte_page(pte);
+		mm->locked_vm -= HPAGE_SIZE >> PAGE_SHIFT;
 		if (pte_dirty(pte))
 			set_page_dirty(page);
 		list_add(&page->lru, &page_list);
@@ -561,6 +562,16 @@ retry:
 				&& (vma->vm_flags & VM_SHARED)));
 	set_huge_pte_at(mm, address, ptep, new_pte);
 
+	/*
+ 	 * Account for huge pages as locked memory.
+ 	 * The locked limits are not enforced at mmap time because hugetlbfs
+ 	 * behaves differently than normal locked memory:  1) The pages are
+ 	 * not pinned immediately, and 2) The pages come from a pre-configured
+ 	 * pool of memory to which the administrator has separately arranged
+ 	 * access.
+ 	 */
+	mm->locked_vm += HPAGE_SIZE >> PAGE_SHIFT;
+
 	if (write_access && !(vma->vm_flags & VM_SHARED)) {
 		/* Optimization, do the COW without a second fault */
 		ret = hugetlb_cow(mm, vma, address, ptep, new_pte);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-09-13 17:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-13 17:58 [PATCH 0/5] [hugetlb] Dynamic huge page pool resizing Adam Litke
2007-09-13 17:59 ` Adam Litke [this message]
2007-09-14  5:41   ` [PATCH 1/5] hugetlb: Account for hugepages as locked_vm Ken Chen
2007-09-14  9:15     ` Mel Gorman
2007-09-13 17:59 ` [PATCH 2/5] hugetlb: Move update_and_free_page Adam Litke
2007-09-13 17:59 ` [PATCH 3/5] hugetlb: Try to grow hugetlb pool for MAP_PRIVATE mappings Adam Litke
2007-09-13 18:06   ` [Libhugetlbfs-devel] " Dave Hansen
2007-09-13 20:21     ` Adam Litke
2007-09-14  5:46       ` David Gibson
2007-09-14 13:33         ` Adam Litke
2007-09-13 17:59 ` [PATCH 4/5] hugetlb: Try to grow hugetlb pool for MAP_SHARED mappings Adam Litke
2007-09-13 22:24   ` Dave McCracken
2007-09-14 14:03     ` Adam Litke
2007-09-13 17:59 ` [PATCH 5/5] hugetlb: Add hugetlb_dynamic_pool sysctl Adam Litke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070913175905.27074.92434.stgit@kernel \
    --to=agl@us.ibm.com \
    --cc=apw@shadowen.org \
    --cc=bill.irwin@oracle.com \
    --cc=dave.mccracken@oracle.com \
    --cc=kenchen@google.com \
    --cc=libhugetlbfs-devel@lists.sourceforge.net \
    --cc=linux-mm@kvack.org \
    --cc=mel@skynet.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox