From: Dave McCracken <dave.mccracken@oracle.com>
To: Adam Litke <agl@us.ibm.com>
Cc: linux-mm@kvack.org, libhugetlbfs-devel@lists.sourceforge.net,
Andy Whitcroft <apw@shadowen.org>, Mel Gorman <mel@skynet.ie>,
Bill Irwin <bill.irwin@oracle.com>, Ken Chen <kenchen@google.com>
Subject: Re: [PATCH 4/5] hugetlb: Try to grow hugetlb pool for MAP_SHARED mappings
Date: Thu, 13 Sep 2007 17:24:48 -0500 [thread overview]
Message-ID: <200709131724.48818.dave.mccracken@oracle.com> (raw)
In-Reply-To: <20070913175940.27074.34082.stgit@kernel>
On Thursday 13 September 2007, Adam Litke wrote:
> +static int gather_surplus_pages(int delta)
> +{
> + struct list_head surplus_list;
> + struct page *page, *tmp;
> + int ret, i;
> + int needed, allocated;
> +
> + needed = (resv_huge_pages + delta) - free_huge_pages;
> + if (!needed)
> + return 0;
It looks here like needed can be less than zero. Do we really intend to
continue with the function if that's true? Or should that test really be "if
(needed <= 0)"?
Dave
next prev parent reply other threads:[~2007-09-13 22:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 17:58 [PATCH 0/5] [hugetlb] Dynamic huge page pool resizing Adam Litke
2007-09-13 17:59 ` [PATCH 1/5] hugetlb: Account for hugepages as locked_vm Adam Litke
2007-09-14 5:41 ` Ken Chen
2007-09-14 9:15 ` Mel Gorman
2007-09-13 17:59 ` [PATCH 2/5] hugetlb: Move update_and_free_page Adam Litke
2007-09-13 17:59 ` [PATCH 3/5] hugetlb: Try to grow hugetlb pool for MAP_PRIVATE mappings Adam Litke
2007-09-13 18:06 ` [Libhugetlbfs-devel] " Dave Hansen
2007-09-13 20:21 ` Adam Litke
2007-09-14 5:46 ` David Gibson
2007-09-14 13:33 ` Adam Litke
2007-09-13 17:59 ` [PATCH 4/5] hugetlb: Try to grow hugetlb pool for MAP_SHARED mappings Adam Litke
2007-09-13 22:24 ` Dave McCracken [this message]
2007-09-14 14:03 ` Adam Litke
2007-09-13 17:59 ` [PATCH 5/5] hugetlb: Add hugetlb_dynamic_pool sysctl Adam Litke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709131724.48818.dave.mccracken@oracle.com \
--to=dave.mccracken@oracle.com \
--cc=agl@us.ibm.com \
--cc=apw@shadowen.org \
--cc=bill.irwin@oracle.com \
--cc=kenchen@google.com \
--cc=libhugetlbfs-devel@lists.sourceforge.net \
--cc=linux-mm@kvack.org \
--cc=mel@skynet.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox