linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Andy Whitcroft <apw@shadowen.org>,
	Christoph Lameter <clameter@sgi.com>,
	linux-mm <linux-mm@kvack.org>, Mel Gorman <mel@skynet.ie>
Subject: [Patch](memory hotplug) Tiny update for hot-add with sparsemem-vmemmap
Date: Thu, 30 Aug 2007 20:04:23 +0900	[thread overview]
Message-ID: <20070830195531.8D7A.Y-GOTO@jp.fujitsu.com> (raw)
In-Reply-To: <20070822095447.05E5.Y-GOTO@jp.fujitsu.com>

This is tiny update for Mel-san's comment about 
memory hotplug with sparse-vmemmap.

  - Add __meminit to sparse_mem_map_populate()
  - Add a comment.

This is for 2.6.23-rc3-mm1.

Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>

---
 mm/sparse-vmemmap.c |    2 +-
 mm/sparse.c         |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Index: current/mm/sparse-vmemmap.c
===================================================================
--- current.orig/mm/sparse-vmemmap.c	2007-08-23 16:19:10.000000000 +0900
+++ current/mm/sparse-vmemmap.c	2007-08-30 19:25:16.000000000 +0900
@@ -137,7 +137,7 @@ int __meminit vmemmap_populate_basepages
 	return 0;
 }
 
-struct page *sparse_mem_map_populate(unsigned long pnum, int nid)
+struct page * __meminit sparse_mem_map_populate(unsigned long pnum, int nid)
 {
 	struct page *map = pfn_to_page(pnum * PAGES_PER_SECTION);
 	int error = vmemmap_populate(map, PAGES_PER_SECTION, nid);
Index: current/mm/sparse.c
===================================================================
--- current.orig/mm/sparse.c	2007-08-23 16:19:10.000000000 +0900
+++ current/mm/sparse.c	2007-08-30 19:31:50.000000000 +0900
@@ -326,6 +326,7 @@ void __init sparse_init(void)
 static inline struct page *kmalloc_section_memmap(unsigned long pnum, int nid,
 						 unsigned long nr_pages)
 {
+	/* This will make the necessary allocations eventually. */
 	return sparse_mem_map_populate(pnum, nid);
 }
 static void __kfree_section_memmap(struct page *memmap, unsigned long nr_pages)

-- 
Yasunori Goto 


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-08-30 11:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-17  7:08 [Patch](memory hotplug) Hot-add " Yasunori Goto
2007-08-20 18:56 ` Christoph Lameter
2007-08-21  1:23   ` Yasunori Goto
2007-08-21 12:59 ` Mel Gorman
2007-08-22  1:28   ` Yasunori Goto
2007-08-30 11:04     ` Yasunori Goto [this message]
2007-08-31 21:00       ` [Patch](memory hotplug) Tiny update for hot-add " Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070830195531.8D7A.Y-GOTO@jp.fujitsu.com \
    --to=y-goto@jp.fujitsu.com \
    --cc=akpm@osdl.org \
    --cc=apw@shadowen.org \
    --cc=clameter@sgi.com \
    --cc=linux-mm@kvack.org \
    --cc=mel@skynet.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox