From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 30 Aug 2007 03:22:37 +0200 From: Nick Piggin Subject: Re: [patch][rfc] radix-tree: be a nice citizen Message-ID: <20070830012237.GA19405@wotan.suse.de> References: <20070829085039.GA32236@wotan.suse.de> <20070829015702.7c8567c2.akpm@linux-foundation.org> <20070829090301.GB32236@wotan.suse.de> <20070829022044.9730888e.akpm@linux-foundation.org> <20070829094503.GC32236@wotan.suse.de> <20070829154531.fd6d67bc.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070829154531.fd6d67bc.akpm@linux-foundation.org> Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: Linux Memory Management List List-ID: On Wed, Aug 29, 2007 at 03:45:31PM -0700, Andrew Morton wrote: > On Wed, 29 Aug 2007 11:45:03 +0200 Nick Piggin wrote: > > > Yeah I'm sure the radix_tree_insert isn't failing, but the > > first kmem_cache_alloc in radix_tree_node_alloc is failing (page > > allocator is giving the backtrace). Because it is GFP_ATOMIC and > > being done under the spinlock. > > OK, that's expected. Add a __GFP_NOWARN to the caller's gfp_t? It eats GFP_ATOMIC reserves (and yes, we could ad a ~__GFP_HIGH, but the allocator still has a small reserve for non-sleeping GFP_KERNEL allocations, so it would eat that). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org