From: Nick Piggin <npiggin@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [patch][rfc] radix-tree: be a nice citizen
Date: Thu, 30 Aug 2007 03:22:37 +0200 [thread overview]
Message-ID: <20070830012237.GA19405@wotan.suse.de> (raw)
In-Reply-To: <20070829154531.fd6d67bc.akpm@linux-foundation.org>
On Wed, Aug 29, 2007 at 03:45:31PM -0700, Andrew Morton wrote:
> On Wed, 29 Aug 2007 11:45:03 +0200 Nick Piggin <npiggin@suse.de> wrote:
>
> > Yeah I'm sure the radix_tree_insert isn't failing, but the
> > first kmem_cache_alloc in radix_tree_node_alloc is failing (page
> > allocator is giving the backtrace). Because it is GFP_ATOMIC and
> > being done under the spinlock.
>
> OK, that's expected. Add a __GFP_NOWARN to the caller's gfp_t?
It eats GFP_ATOMIC reserves (and yes, we could ad a ~__GFP_HIGH, but
the allocator still has a small reserve for non-sleeping GFP_KERNEL
allocations, so it would eat that).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-08-30 1:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-29 8:50 Nick Piggin
2007-08-29 8:57 ` Andrew Morton
2007-08-29 9:03 ` Nick Piggin
2007-08-29 9:20 ` Andrew Morton
2007-08-29 9:45 ` Nick Piggin
2007-08-29 22:45 ` Andrew Morton
2007-08-30 1:22 ` Nick Piggin [this message]
2007-08-30 2:08 ` Andrew Morton
2007-08-30 3:16 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070830012237.GA19405@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox