From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 29 Aug 2007 11:45:03 +0200 From: Nick Piggin Subject: Re: [patch][rfc] radix-tree: be a nice citizen Message-ID: <20070829094503.GC32236@wotan.suse.de> References: <20070829085039.GA32236@wotan.suse.de> <20070829015702.7c8567c2.akpm@linux-foundation.org> <20070829090301.GB32236@wotan.suse.de> <20070829022044.9730888e.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070829022044.9730888e.akpm@linux-foundation.org> Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: Linux Memory Management List List-ID: On Wed, Aug 29, 2007 at 02:20:44AM -0700, Andrew Morton wrote: > On Wed, 29 Aug 2007 11:03:01 +0200 Nick Piggin wrote: > > > On Wed, Aug 29, 2007 at 01:57:02AM -0700, Andrew Morton wrote: > > > On Wed, 29 Aug 2007 10:50:39 +0200 Nick Piggin wrote: > > > > > > > ISTR that last time I sent you a patch to do the same thing, you > > > > had some objections. I can't remember what they were though, but > > > > I guess you didn't end up merging it. > > > > > > So you can't remember what the problem was, and I have to work iyut > > > out again. Is this efficient? > > > > No, but better than leaving it unfixed. It was years ago. I did try > > to find it. > > > > ho hum. > > > > > > > I was reminded by the problem after seeing an atomic allocation > > > > failure trace from pagecache radix tree inesrtion. > > > > > > wot? radix-tree node allocation for pagecache insertion doesn't fail. > > > > The atomic allocation that's part of node allocation can. > > radix-tree node allocations under add_to_page_cache() can't fail. Or if they > can, there's some bug. IOW, I don't have a clue what you're trying to tell me. > > Can we start again? Oh, OK. Yeah I'm sure the radix_tree_insert isn't failing, but the first kmem_cache_alloc in radix_tree_node_alloc is failing (page allocator is giving the backtrace). Because it is GFP_ATOMIC and being done under the spinlock. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org